starlingx
/
nfv
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_21776\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 21776 \u003c21776@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_21776\u003e replied on the change"}
This commit is contained in:
Gerrit User 21776 2022-08-25 19:55:51 +00:00 committed by Gerrit Code Review
parent 28662b3377
commit 68b1c3bb2b
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
eac89686e2ff31f2e5a8e3b529a469f90cc9f990
View File

@ -70,6 +70,30 @@
},
"revId": "eac89686e2ff31f2e5a8e3b529a469f90cc9f990",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "322e7d45_8567beb3",
"filename": "nfv/nfv-vim/nfv_vim/api/acl/policies/sw_update_strategy_policy.py",
"patchSetId": 3
},
"lineNbr": 26,
"author": {
"id": 21776
},
"writtenOn": "2022-08-25T19:55:51Z",
"side": 1,
"message": "I added a comment.\nI\u0027ve tested the patch strategy create, delete, show, apply, and abort, and ensured it gets through my changes (admin is allowed on all, reader allowed on show). I don\u0027t think testing the apply completely is needed, since that part of the code was not changed. It would also not be fair to not test the other commands like fw_update, kube_upgrade, kube_rootca_update, sw_patch_strategy. Lots of testing overhead for behavior that was not changed by this commit.",
"parentUuid": "da396c6e_f0d11cc3",
"range": {
"startLine": 26,
"startChar": 21,
"endLine": 26,
"endChar": 27
},
"revId": "eac89686e2ff31f2e5a8e3b529a469f90cc9f990",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}