Update patch set 14
Patch Set 14:
(8 comments)
Patch-set: 14
Reviewer: Gerrit User 28715 <28715@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 28715 \u003c28715@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35748 \u003c35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926
Gerrit Code Review
parent
2660fa54a7
commit
d8fb709b23
|
|
@ -0,0 +1,141 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e27b8431_aa417bf7",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 996,
|
||||
"author": {
|
||||
"id": 9926
|
||||
},
|
||||
"writtenOn": "2024-04-10T13:52:12Z",
|
||||
"side": 1,
|
||||
"message": "recommend use of constant instead so these are easier to identify in future; several instances in this file",
|
||||
"range": {
|
||||
"startLine": 996,
|
||||
"startChar": 59,
|
||||
"endLine": 996,
|
||||
"endChar": 66
|
||||
},
|
||||
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d4040f29_be4827ec",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 1407,
|
||||
"author": {
|
||||
"id": 9926
|
||||
},
|
||||
"writtenOn": "2024-04-10T13:52:12Z",
|
||||
"side": 1,
|
||||
"message": "not necessarily only, as may be used for other orchestrators in future",
|
||||
"range": {
|
||||
"startLine": 1407,
|
||||
"startChar": 18,
|
||||
"endLine": 1407,
|
||||
"endChar": 23
|
||||
},
|
||||
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f0f610a3_5203af71",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 1922,
|
||||
"author": {
|
||||
"id": 9926
|
||||
},
|
||||
"writtenOn": "2024-04-10T13:52:12Z",
|
||||
"side": 1,
|
||||
"message": "this is for ignoring each alarm up to specified amount of time. (i.e. generic, though currently used for patch strategy)",
|
||||
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e5b29c3d_bd901640",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 2154,
|
||||
"author": {
|
||||
"id": 9926
|
||||
},
|
||||
"writtenOn": "2024-04-10T13:52:12Z",
|
||||
"side": 1,
|
||||
"message": "comment should be more generic",
|
||||
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c41343c5_fbb8d23b",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 2163,
|
||||
"author": {
|
||||
"id": 9926
|
||||
},
|
||||
"writtenOn": "2024-04-10T13:52:12Z",
|
||||
"side": 1,
|
||||
"message": "comment should be more generic",
|
||||
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "8eeda8bd_fb7af7ea",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 2165,
|
||||
"author": {
|
||||
"id": 9926
|
||||
},
|
||||
"writtenOn": "2024-04-10T13:52:12Z",
|
||||
"side": 1,
|
||||
"message": "shouldnt this just ignore the alarm that met the condition at 2164 rather than all elements of self._ignore_alarms_conditional ?",
|
||||
"range": {
|
||||
"startLine": 2165,
|
||||
"startChar": 52,
|
||||
"endLine": 2165,
|
||||
"endChar": 96
|
||||
},
|
||||
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4b125f82_7289c3fe",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 2181,
|
||||
"author": {
|
||||
"id": 9926
|
||||
},
|
||||
"writtenOn": "2024-04-10T13:52:12Z",
|
||||
"side": 1,
|
||||
"message": "comment on the purpose of this code block. It appears to be unconditionally removing all _ignore_alarms_condition which doesnt appear correct",
|
||||
"revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -0,0 +1,27 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "405975d0_c048f82f",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 12
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 9926
|
||||
},
|
||||
"writtenOn": "2024-04-10T13:52:12Z",
|
||||
"side": 1,
|
||||
"message": "specified number of seconds",
|
||||
"range": {
|
||||
"startLine": 11,
|
||||
"startChar": 14,
|
||||
"endLine": 11,
|
||||
"endChar": 20
|
||||
},
|
||||
"revId": "98519be2617b3046df4b4bf1fdd2c5a7baa90c5c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue