starlingx/test
Code Issues Proposed changes

Fixed timing issue with wait_for_pods_status_running

Browse Source 
In test_sanity_regression::wait_for_pods_status_running we
were running into a timing issue where get_pods was sometimes
happening before the pods were created. This led to an assert
failure. Adjusted the code to use validate_equals_with_retry.

Change-Id: I90f6b3cb5e2b13d53a62ddbb7bc34ac8564c21d5
Signed-off-by: croy <Christian.Roy@windriver.com>
This commit is contained in:
croy
2025-05-20 15:06:19 -04:00
parent b2fe25d35b
commit 65627cece5
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
testcases/cloud_platform/sanity/test_sanity_regression.py
View File

@@ -551,14 +551,22 @@ def wait_for_pods_status_running(ssh_connection: SSHConnection) -> bool:
bool: True if they are running, False otherwise bool: True if they are running, False otherwise
""" """
pods = KubectlGetPodsKeywords(ssh_connection).get_pods()
# Wait until the pods are created.
def get_number_of_consumer_pods():
pods = KubectlGetPodsKeywords(ssh_connection).get_pods()
consumer_pods = pods.get_pods_start_with("resource-consumer")
return len(consumer_pods)
validate_equals_with_retry(get_number_of_consumer_pods, 2, "There are 2 resource-consumer pods created")
# Get the full names of those consumer pods
pods = KubectlGetPodsKeywords(ssh_connection).get_pods()
consumer_pods = pods.get_pods_start_with("resource-consumer") consumer_pods = pods.get_pods_start_with("resource-consumer")
assert len(consumer_pods) == 2, "Incorrect number of consumer_pods were created"
consumer_pod1_name = consumer_pods[0].get_name() consumer_pod1_name = consumer_pods[0].get_name()
consumer_pod2_name = consumer_pods[1].get_name() consumer_pod2_name = consumer_pods[1].get_name()
# wait for all pods to be running # Wait for all pods to be running
kubectl_get_pods_keywords = KubectlGetPodsKeywords(ssh_connection) kubectl_get_pods_keywords = KubectlGetPodsKeywords(ssh_connection)
consumer_pod1_running = kubectl_get_pods_keywords.wait_for_pod_status(consumer_pod1_name, "Running") consumer_pod1_running = kubectl_get_pods_keywords.wait_for_pod_status(consumer_pod1_name, "Running")
consumer_pod2_running = kubectl_get_pods_keywords.wait_for_pod_status(consumer_pod2_name, "Running") consumer_pod2_running = kubectl_get_pods_keywords.wait_for_pod_status(consumer_pod2_name, "Running")