Update patch set 19
Patch Set 19: (6 comments) Patch-set: 19
This commit is contained in:
Gerrit User 33136
Gerrit Code Review
parent
8da5ac1426
commit
4aca5a8396
|
|
@ -34,6 +34,24 @@
|
|||
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "666db0bc_921bb3c9",
|
||||
"filename": "tools/opae/opae-sdk/debian/deb_folder/opae-devel.install",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 4,
|
||||
"author": {
|
||||
"id": 33136
|
||||
},
|
||||
"writtenOn": "2022-10-26T13:12:27Z",
|
||||
"side": 1,
|
||||
"message": "Are you sure that we need sudo? I dont see that in the OPAE documentaion.\nThe files are located at the same path as for CentOS.\nThe Debian packages are equivalent to the RPM packages in this sense.",
|
||||
"parentUuid": "de2278a8_c3e041b4",
|
||||
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -51,6 +69,24 @@
|
|||
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "bb755bf0_6be31546",
|
||||
"filename": "tools/opae/opae-sdk/debian/deb_folder/opae-tools-extra.install",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 27,
|
||||
"author": {
|
||||
"id": 33136
|
||||
},
|
||||
"writtenOn": "2022-10-26T13:12:27Z",
|
||||
"side": 1,
|
||||
"message": "Are you sure that we need sudo? I dont see that in the OPAE documentaion.\nThe files are located at the same path as for CentOS.\nThe Debian packages are equivalent to the RPM packages in this sense.",
|
||||
"parentUuid": "cf815d26_c4bd8690",
|
||||
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -68,6 +104,24 @@
|
|||
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "682e7644_fa16c61d",
|
||||
"filename": "tools/opae/opae-sdk/debian/deb_folder/opae-tools.install",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 5,
|
||||
"author": {
|
||||
"id": 33136
|
||||
},
|
||||
"writtenOn": "2022-10-26T13:12:27Z",
|
||||
"side": 1,
|
||||
"message": "Are you sure that we need sudo? I dont see that in the OPAE documentaion.\nThe files are located at the same path as for CentOS.\nThe Debian packages are equivalent to the RPM packages in this sense.",
|
||||
"parentUuid": "ef07f105_39213ac3",
|
||||
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -84,6 +138,24 @@
|
|||
"message": "This makes me very uneasy. We\u0027re writing their license file for them? Are you sure there isn\u0027t a license somewhere governing this?",
|
||||
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "91f7ac4a_41fd21c5",
|
||||
"filename": "tools/opae/python3-opae.admin/debian/dl_hook",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 30,
|
||||
"author": {
|
||||
"id": 33136
|
||||
},
|
||||
"writtenOn": "2022-10-26T13:12:27Z",
|
||||
"side": 1,
|
||||
"message": "The contents are identical to the license provided in the OPAE ZIP file.\nNext commit I will extract it from the ZIP file instead.",
|
||||
"parentUuid": "ee543466_3a45114f",
|
||||
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -17,6 +17,24 @@
|
|||
"revId": "61288cd18c245fe7f8152e9c92b993a272e06f2f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "b93e1bc1_f1225cbe",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 17
|
||||
},
|
||||
"lineNbr": 2,
|
||||
"author": {
|
||||
"id": 33136
|
||||
},
|
||||
"writtenOn": "2022-10-26T13:12:27Z",
|
||||
"side": 1,
|
||||
"message": "I will fix that in next commit.",
|
||||
"parentUuid": "f08337ff_acef813f",
|
||||
"revId": "61288cd18c245fe7f8152e9c92b993a272e06f2f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -34,6 +52,24 @@
|
|||
"revId": "61288cd18c245fe7f8152e9c92b993a272e06f2f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "36f2b380_a573d5a4",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 17
|
||||
},
|
||||
"lineNbr": 4,
|
||||
"author": {
|
||||
"id": 33136
|
||||
},
|
||||
"writtenOn": "2022-10-26T13:12:27Z",
|
||||
"side": 1,
|
||||
"message": "DONE",
|
||||
"parentUuid": "e0d3901f_e2fa306d",
|
||||
"revId": "61288cd18c245fe7f8152e9c92b993a272e06f2f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
|||
Loading…
Reference in New Issue