starlingx/utilities
Code Issues Proposed changes

Remove gen-prestaged-iso.sh max file size limitation

Browse Source 
Current version 1.1.11 of 'mkisofs' (also known as genisoimage) no
longer errors out on input files later than 4G. The 4G limitation
only applies to ISO images that need to be ISO-9660 compliant.

StarlingX prestaging ISO images are not required to comply
to ISO-9660 as they never have. The gen-prestaged-iso.sh script
has always warned that the created filesystem does not conform
to ISO-9600 and there has never been a problem installing images
produced with this tool.

Therefore, this update removes the input filesize check which
is preventing system administrators from creating prestaged
iso images from Debian StarlingX images that exceed 4 GB

Test Plan:

PEND: Create and install prestaged ISO images from an input
      ISOs that are larger than 4G ; sizes of 4.1G, 6G and 10G.
PASS: ... 4.1G
PASS: ... 5.8G
PASS: ... 14G

Closes-Bug: 2023592
Change-Id: I2ac3f3ad159892aed9cdb091c5ab3d93e7630430
Signed-off-by: Eric MacDonald <eric.macdonald@windriver.com>
This commit is contained in:
Eric MacDonald 2023-06-12 20:33:52 +00:00
parent d98212da96
commit cb27342079
1 changed files with 1 additions and 1 deletions

2
utilities/platform-util/scripts/gen-prestaged-iso.sh

@ -487,7 +487,7 @@ check_required_param "--input" "${INPUT_ISO}"
check_required_param "--output" "${OUTPUT_ISO}"
check_files_exist ${INPUT_ISO} ${PATCHES[@]} ${IMAGES[@]} ${KS_SETUP} ${KS_ADDON} ${KICKSTART_PATCHES[@]}
check_files_size ${INPUT_ISO} ${PATCHES[@]} ${IMAGES[@]} ${KS_SETUP} ${KS_ADDON} ${KICKSTART_PATCHES[@]}
check_files_size ${PATCHES[@]} ${IMAGES[@]} ${KS_SETUP} ${KS_ADDON} ${KICKSTART_PATCHES[@]}
if [[ -e "${OUTPUT_ISO}" ]]; then
log_fatal "${OUTPUT_ISO} exists. Delete before you execute this script."