This button was not working because we sync the change before sending
a review, which reset the pending state. Determine whether we are
intending to submit the change before performing that sync, and
remember it after the sync is done.
Change-Id: I8c85c2a8fec50b50fb92037f6dcbcc7917c3baff
The change view did not display comments from previous patchsets,
only comments associated with the patchset of the current message.
This displays them from all patchsets, annotating them with the
patchset number when it is different.
Note, the line comments were correctly displayed in the diff view.
Change-Id: Ieda0de0bb24800b9c3f577f339ca1338f2f1cc38
Even though we won't usually display it, binary data may show up
in a diff. We can't decode it to display it, so just replace it
with a placeholder string so we don't crash.
Change-Id: I4794e707745ed8315afec00c1981e239ec98ef0e
Default config location was changed recently. This commit
updates information about where this config should be placed in
message printed if there is no config file found at all.
Change-Id: I847005182d2a31a25b51886bd4997ce8a74075c0
This is necessary on systems where the username may not be present
(e.g., gerrit-review.googlesource.com).
Change-Id: Ia91b1e9b0fb0f98728dca46a488a92a97a301274
The behavior for searching "file" more closely matches the documented
behavior for "path". Implement "path" the same as "file", then update
"file" so that the non-regex form matches path components.
Change-Id: I03bf6d5232472069ea288b1ce0fe955469791af1
When searching for file: we previously would return changes with
any revisions with matching files. Gerrit itself only considers
the latest revision, so match its behavior.
Also, correct a py3 issue with the message attribute not existing
on the SearchSyntaxError exception class.
Change-Id: I645e58b010cc3a2f74883e97f8be3634efbc2a20
Add '<' and '>' keybindings which are used for diffing pairs of
patchsets. '<' moves to the previous pair, '>' to the next.
Change-Id: I46d24f6e62f113e16be2445a8e52384086c01c8e
This change changes the default location for the gertty configuration
file that takes precedence if none is supplied on the command line to
~/.config/gertty/gertty.yaml. If that file does not exist, the previous
location of ~/.gertty.yaml is consulted as a fallback.
Change-Id: I5ee6224219b0229c7b1ba17205c3f4cf8fb1d62b
Story: 2002119
Task: 19798
File comments were causing an exception when displayed on the
change view because python3 does not allow comparing None to int,
and file comments have a line number of None.
To correct this, use 0 as the line number for file comments whin
sorting and displaying them in the change view; there is no line
0 so this minor aliasing shouldn't cause any collisions.
Also, add a newline to the end of file comments, just as regular
inline comments (otherwise if a file comment was followed by a
line comment, they would appear on the same line).
Change-Id: Iedf88cdfd83adbc405e26cb013c9f57481d50c90
There are some lines which were being read as byte arrays and
were not decoded into strings which was causing them to bypass
tab expansion (because they caused an exception which was caught
and the un-expanded text was used instead). Correct those cases
and disable the exception handler so that we can identify any
other cases by triggering a crash.
Change-Id: I4b34132290fc8611cc770d572068197b33c0789c
This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.
This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.
This update should result in no functional change.
For more information see the thread at
http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html
Change-Id: If39f30fe67ab6a95df5cbfb00cdc2cb1eb77e5d0
tabs are displayed as question mark by urwid, so need replacing.
While we are replacing, might as well mark them like in the web UI.
Ideally I would want to use a slightly different color for them,
but that would require to add many new colors in the config (context,
full new line, part of new line) and would not be very compatible
with 8-colors terminals -- the '»' character is hopefully rarely used
enough to be useable as is.
Change-Id: Ic974774bf546765fa5b3e9266aee8ff973865502
- Add a config option to enable closing a change after a review
is saved, and going back to the change list.
- Enable reviewKeys from the change page to also work on the
diff view.
Change-Id: I37d907132a012d074d38345f15ef83ec7d9f3e6c
Many of the other keybindings seem to have emacs defaults, so add
page-up/page-down, for use on laptop keyboards without real page
keys.
Change-Id: I02bd8bebe9bfea89133d2eb28322bcf5fabaacf8
The gerrit ui shows the inline comments on the change overview without
having to open the diff screen. This is useful for following
discussions on changes so add this to gertty as well.
Change-Id: I976ec5584e978ce4aee7075bc45394193c104889
The exampkle gertty yaml files indicate that there is a 'lock-file'
parameter per server that allows you to define the location of a
lockfile. Code to handle that exists in config.py but the option is not
defined in the schema, so errors like this cause the process to exit:
voluptuous.error.MultipleInvalid: extra keys not allowed @ data['servers'][0]['lock-file']
Change-Id: Ia03ed9d2de5d598eeafc6e8ffab30c99bd9fded6
The .message attribute was dropped from the base exception class
in py3. Since we use it, set it directly.
Change-Id: I27124c6d00216b335351ef6985ddf869f2fd1366
James E. Blair
Slawek Kaplonski
Nate Johnston
OpenDev Sysadmins
Zuul
Ian Wienand
Dominique Martinet
Doug Wiegley
Tobias Henkel
Tristan Cacqueray
Clint Byrum
Natal Ngétal