The behavior for searching "file" more closely matches the documented
behavior for "path".  Implement "path" the same as "file", then update
"file" so that the non-regex form matches path components.

Change-Id: I03bf6d5232472069ea288b1ce0fe955469791af1

When searching for file: we previously would return changes with
any revisions with matching files.  Gerrit itself only considers
the latest revision, so match its behavior.

Also, correct a py3 issue with the message attribute not existing
on the SearchSyntaxError exception class.

Change-Id: I645e58b010cc3a2f74883e97f8be3634efbc2a20

Add '<' and '>' keybindings which are used for diffing pairs of
patchsets.  '<' moves to the previous pair, '>' to the next.

Change-Id: I46d24f6e62f113e16be2445a8e52384086c01c8e

This should work in all current-ish versions.

Change-Id: Ic97fcfc554fe7dd5cfa5a9298a4b13892d1c97f8

Change-Id: I1992146163b4a2ad9e70751c4ebd6b6a6663e441

This change changes the default location for the gertty configuration
file that takes precedence if none is supplied on the command line to
~/.config/gertty/gertty.yaml.  If that file does not exist, the previous
location of ~/.gertty.yaml is consulted as a fallback.

Change-Id: I5ee6224219b0229c7b1ba17205c3f4cf8fb1d62b
Story: 2002119
Task: 19798

This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.

File comments were causing an exception when displayed on the
change view because python3 does not allow comparing None to int,
and file comments have a line number of None.

To correct this, use 0 as the line number for file comments whin
sorting and displaying them in the change view; there is no line
0 so this minor aliasing shouldn't cause any collisions.

Also, add a newline to the end of file comments, just as regular
inline comments (otherwise if a file comment was followed by a
line comment, they would appear on the same line).

Change-Id: Iedf88cdfd83adbc405e26cb013c9f57481d50c90

There are some lines which were being read as byte arrays and
were not decoded into strings which was causing them to bypass
tab expansion (because they caused an exception which was caught
and the un-expanded text was used instead).  Correct those cases
and disable the exception handler so that we can identify any
other cases by triggering a crash.

Change-Id: I4b34132290fc8611cc770d572068197b33c0789c

This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.

This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.

This update should result in no functional change.

For more information see the thread at

 http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html

Change-Id: If39f30fe67ab6a95df5cbfb00cdc2cb1eb77e5d0

tabs are displayed as question mark by urwid, so need replacing.
While we are replacing, might as well mark them like in the web UI.

Ideally I would want to use a slightly different color for them,
but that would require to add many new colors in the config (context,
full new line, part of new line) and would not be very compatible
with 8-colors terminals -- the '»' character is hopefully rarely used
enough to be useable as is.

Change-Id: Ic974774bf546765fa5b3e9266aee8ff973865502

Change-Id: Idb377eae4a2b52760cb810b590a75b5aea522968

- Add a config option to enable closing a change after a review
  is saved, and going back to the change list.
- Enable reviewKeys from the change page to also work on the
  diff view.

Change-Id: I37d907132a012d074d38345f15ef83ec7d9f3e6c

Many of the other keybindings seem to have emacs defaults, so add
page-up/page-down, for use on laptop keyboards without real page
keys.

Change-Id: I02bd8bebe9bfea89133d2eb28322bcf5fabaacf8

The gerrit ui shows the inline comments on the change overview without
having to open the diff screen. This is useful for following
discussions on changes so add this to gertty as well.

Change-Id: I976ec5584e978ce4aee7075bc45394193c104889

This change logs failed POST text response early to prevent JSONDecodeError
exceptions.

Change-Id: Iee88fdfb201dfca282e2098d818df7fc77d33784

Python3 does not allow comparing int's to None directly.

Change-Id: Id9e889284096e407d59c3938ecd07427ba42e350

Change-Id: I0869d9fcd19e74ce30bbb4fef51b710c41150a14

With fedora it's better to use dnf. Available since fedora 18.

Change-Id: I71da8ca84d63aaf595ffa38a2cfbdacd25903ae0

The exampkle gertty yaml files indicate that there is a 'lock-file'
parameter per server that allows you to define the location of a
lockfile.  Code to handle that exists in config.py but the option is not
defined in the schema, so errors like this cause the process to exit:

voluptuous.error.MultipleInvalid: extra keys not allowed @ data['servers'][0]['lock-file']

Change-Id: Ia03ed9d2de5d598eeafc6e8ffab30c99bd9fded6

The .message attribute was dropped from the base exception class
in py3.  Since we use it, set it directly.

Change-Id: I27124c6d00216b335351ef6985ddf869f2fd1366

And change the value from splitGraph to split-graph for consistency.

Change-Id: Ia98aac367702933b205b4d8cea5b5579ebd9a062

This commit makes the size column configurable to graphs by
configuration file. And this commit adds color styles by thresholds
which are configurable.

Change-Id: Ifdc6961efbb178cc314c0fbd4d948a1ba19dcdd6

Gerrit servers under some configurations will return a result that
doesn't fail in checkResponse but isn't JSON. When that happens the
action being synced is discarded and lost.

This has been the case for nearly 4 years as far as I can tell.

Change-Id: I9f4c36cf50acefab4806e7617226c979465d384d

Yaml.load() return Python object may be dangerous if you receive a YAML
document from an untrusted source such as the Internet. The function
yaml.safe_load() limits this ability to simple Python objects like integers or
lists.

Reference:
https://security.openstack.org/guidelines/dg_avoid-dangerous-input-parsing-libraries.html

Change-Id: I1793ee3484f51dd663052e367d86f96f2f7598ea

If a change's parent is outdated, show it even if the parent is
merged.

Change-Id: Ifee3980d1f8ca83a88d5c433e790e786815a083f

This patch adds Zuul to the `hide-comments` configuration option so
that Zuul v3 comments are handled just like Jenkins comments.

Change-Id: Id2a6008b59522291f9c60e32bc47c5fb076d1362

With keys being a view we need to convert it to a list explicitly now.

Change-Id: I99b5279d98b6d79bcf6e891040877d7b89bbcf7c

AUTHORS ChangeLog build are created when running:
python setup.py install

But we don't want git to commit these files.

Change-Id: I670e029c1e4788d538ff8ea4d483bcd737dc10b7

Add 'message' optional parameter to reviewkeys which can be use to have
a shortcut to leave recheck in reviews (example of use case).

reviewkeys:
  - key: 'meta 4'
    approvals: []
    message: 'recheck'

It updates the doc and also the openstack-gertty.yaml since it can be
useful for all OpenStack reviewers.

Change-Id: I81f3cc8374fe1872efb71d4b2bc1c647b118d43f

It is very confusing to new Gertty users like me that it seems to
function fine except the search key is a noop on MacOS, and the
current documentation for fixing this is buried in a 250 line
configuration example.

This is just a minor documentation fix to make the possible need
for a custom key mapping on MacOS more prominent.

Change-Id: I8053de3a0a64ebeeec9d2d400766a8debe5c17fa

If a change has many revisions, loading the change screen may be
slow because we verify the presence of each commit and its parent
individually.

Instead, do that in a batch to speed things up.

Change-Id: Ib4b1c34500b98b8bb7307a5aaca86802a15e635d