x/anvil
Code Issues Proposed changes

py2rpm: Don't crash when some manifest fields are not defined

Browse Source 
Make py2rpm handle gracefully (instead of crashing) when authors
leave license or homepage fields unspecified in their package
manifest.

Test case: PuLP==1.5.4

Change-Id: I0b99487afae2e03df24e53e94b02ebddfd9edaf1
This commit is contained in:
Ivan A. Melnikov 2014-01-29 17:43:32 +04:00
parent 2ff4595c9e
commit c159246512
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/py2rpm
View File

@ -545,9 +545,11 @@ def build_rpm(options, filename):
tags.append(("Vendor", "%s <%s>" % (info["author"], info["author-email"])))
tags.append(("Url", info["home-page"]))
max_name_len = max(len(tag[0]) for tag in tags)
for tag in tags:
print >> spec_file, "%s:" % tag[0], " " * (
max_name_len - len(tag[0]) + 1), one_line(tag[1], max_len=-1)
for tag_name, tag_value in tags:
if not tag_value:
tag_value = 'Unknown'
print >> spec_file, "%s:" % tag_name, " " * (
max_name_len - len(tag_name) + 1), one_line(tag_value, max_len=-1)
if rpm_requires:
print >> spec_file, rpm_requires
if rpm_conflicts: