x
/
ciwatch
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 7979 <7979@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 7979 2016-04-19 21:34:34 +00:00 committed by Gerrit Code Review
parent 2ee9184d95
commit 4bd7b887ef
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
699dae47e3f7e66a0a804c17c996b5d0217c682c
View File

@ -16,6 +16,24 @@
"revId": "699dae47e3f7e66a0a804c17c996b5d0217c682c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_2740e633",
"filename": "ciwatch/events.py",
"patchSetId": 3
},
"lineNbr": 36,
"author": {
"id": 7979
},
"writtenOn": "2016-04-19T21:34:34Z",
"side": 1,
"message": "Agree. I do not remember what was the reasoning for me to do so, I think I was getting rid of \"global\" config and wanted to make dependency explicit to start with. To make it testable, we would pass the config into __init__ instead of having instance of CIWatchApp in here. Would you like me to update this patch, or do it in the follow up?",
"parentUuid": "1a122d0e_68e470e0",
"revId": "699dae47e3f7e66a0a804c17c996b5d0217c682c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}