Minor refactorings
This commit is contained in:
		@@ -32,7 +32,7 @@ class BaseOSUtils(object):
 | 
			
		||||
        (out, err) = p.communicate()
 | 
			
		||||
        return (out, err, p.returncode)
 | 
			
		||||
 | 
			
		||||
    def sanitize_shell_input(shell, value):
 | 
			
		||||
    def sanitize_shell_input(self, value):
 | 
			
		||||
        pass
 | 
			
		||||
 | 
			
		||||
    def create_user(self, username, password, password_expires=False):
 | 
			
		||||
@@ -44,7 +44,7 @@ class BaseOSUtils(object):
 | 
			
		||||
    def add_user_to_local_group(self, username, groupname):
 | 
			
		||||
        pass
 | 
			
		||||
 | 
			
		||||
    def set_host_name(shell, new_host_name):
 | 
			
		||||
    def set_host_name(self, new_host_name):
 | 
			
		||||
        pass
 | 
			
		||||
 | 
			
		||||
    def get_user_home(self, username):
 | 
			
		||||
 
 | 
			
		||||
@@ -207,10 +207,10 @@ class WindowsUtils(base.BaseOSUtils):
 | 
			
		||||
        LOG.debug('Home directory not found for user \'%s\'' % username)
 | 
			
		||||
        return None
 | 
			
		||||
 | 
			
		||||
    def sanitize_shell_input(shell, value):
 | 
			
		||||
    def sanitize_shell_input(self, value):
 | 
			
		||||
        return value.replace('"', '\\"')
 | 
			
		||||
 | 
			
		||||
    def set_host_name(shell, new_host_name):
 | 
			
		||||
    def set_host_name(self, new_host_name):
 | 
			
		||||
        conn = wmi.WMI(moniker='//./root/cimv2')
 | 
			
		||||
        comp = conn.Win32_ComputerSystem()[0]
 | 
			
		||||
        if comp.Name != new_host_name:
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user