x/cloudbase-init
Code Issues Proposed changes

Minor refactorings

Browse Source
This commit is contained in:
Alessandro Pilotti
2013-03-30 17:29:19 +02:00
parent 3b807d53c4
commit 581928a5ee
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cloudbaseinit/osutils/base.py
View File

@@ -32,7 +32,7 @@ class BaseOSUtils(object):
(out, err) = p.communicate() (out, err) = p.communicate()
return (out, err, p.returncode) return (out, err, p.returncode)
def sanitize_shell_input(shell, value): def sanitize_shell_input(self, value):
pass pass
def create_user(self, username, password, password_expires=False): def create_user(self, username, password, password_expires=False):
@@ -44,7 +44,7 @@ class BaseOSUtils(object):
def add_user_to_local_group(self, username, groupname): def add_user_to_local_group(self, username, groupname):
pass pass
def set_host_name(shell, new_host_name): def set_host_name(self, new_host_name):
pass pass
def get_user_home(self, username): def get_user_home(self, username):

4
cloudbaseinit/osutils/windows.py
View File

@@ -207,10 +207,10 @@ class WindowsUtils(base.BaseOSUtils):
LOG.debug('Home directory not found for user \'%s\'' % username) LOG.debug('Home directory not found for user \'%s\'' % username)
return None return None
def sanitize_shell_input(shell, value): def sanitize_shell_input(self, value):
return value.replace('"', '\\"') return value.replace('"', '\\"')
def set_host_name(shell, new_host_name): def set_host_name(self, new_host_name):
conn = wmi.WMI(moniker='//./root/cimv2') conn = wmi.WMI(moniker='//./root/cimv2')
comp = conn.Win32_ComputerSystem()[0] comp = conn.Win32_ComputerSystem()[0]
if comp.Name != new_host_name: if comp.Name != new_host_name: