x
/
deb-python-tempest-lib
Code Issues Proposed changes

Change attach_id to volume_id in show_volume_attachment 

The id in the os-volume_attachments GET request is actually the
volume id [1] so rename the variable so people like me aren't
super confused when writing code with tempest-lib.

[1] http://tinyurl.com/hl2mcwb

Change-Id: Ie5454963ce931a7238e34737b638e171c69d0125
This commit is contained in:
Matt Riedemann 2016-01-22 11:49:56 -08:00 committed by Jordan Pittier
parent 57e4d853e5
commit d5e4067268
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tempest_lib/services/compute/servers_client.py
View File

@ -319,10 +319,10 @@ class ServersClient(rest_client.RestClient):
self.validate_response(schema.detach_volume, resp, body)
return rest_client.ResponseBody(resp, body)
def show_volume_attachment(self, server_id, attach_id):
def show_volume_attachment(self, server_id, volume_id):
"""Return details about the given volume attachment."""
resp, body = self.get('servers/%s/os-volume_attachments/%s' % (
server_id, attach_id))
server_id, volume_id))
body = json.loads(body)
self.validate_response(schema.show_volume_attachment, resp, body)
return rest_client.ResponseBody(resp, body)

2
tempest_lib/tests/services/compute/test_servers_client.py
View File

@ -592,7 +592,7 @@ class TestServersClient(base.BaseComputeServiceTest):
'tempest_lib.common.rest_client.RestClient.get',
{'volumeAttachment': self.FAKE_COMMON_VOLUME},
server_id=self.server_id,
attach_id='fake-attach-id'
volume_id=self.FAKE_COMMON_VOLUME['volumeId']
)
def test_list_volume_attachments_with_str_body(self):