x/devstack-plugin-libvirt-qemu
Code Issues Proposed changes

Update patch set 1

Browse Source 
Patch Set 1: Code-Review-1

(2 comments)

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 16688
2017-07-13 13:58:17 +00:00
committed by Gerrit Code Review
parent 38e2890285
commit 54320c8221
2 changed files with 48 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
0762b9b7b24ea5b78adac65aeeddc4b0d1a06379 Normal file
View File

@@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "1f1a1f67_f24a537e",
"filename": "test-requirements.txt",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 16688
},
"writtenOn": "2017-07-13T13:58:17Z",
"side": 1,
"message": "We need this for docs and releasenotes tests.",
"revId": "0762b9b7b24ea5b78adac65aeeddc4b0d1a06379",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}

27
6aa96dd912b0ee1fd9eab2eeb2fa215f9f9ee840 Normal file
View File

@@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "1f1a1f67_9280bf8d",
"filename": "tox.ini",
"patchSetId": 1
},
"lineNbr": 46,
"author": {
"id": 16688
},
"writtenOn": "2017-07-13T13:58:17Z",
"side": 0,
"message": "I would like to keep docs and releasenotes tests. Now it\u0027s not tested in the gate, but we can execute this manually.",
"range": {
"startLine": 41,
"startChar": 0,
"endLine": 46,
"endChar": 106
},
"revId": "6aa96dd912b0ee1fd9eab2eeb2fa215f9f9ee840",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}