Update patch set 11
Patch Set 11: Code-Review-1 (3 comments) Patch-set: 11 Label: Code-Review=-1
This commit is contained in:
parent
baa707751b
commit
953fd13907
73
96316b129a43ee147cd4cd6caa55ac7bb6359882
Normal file
73
96316b129a43ee147cd4cd6caa55ac7bb6359882
Normal file
@ -0,0 +1,73 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a430d35_bca6090e",
|
||||
"filename": "fuel_ccp_entrypoint/start_script.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 186,
|
||||
"author": {
|
||||
"id": 12039
|
||||
},
|
||||
"writtenOn": "2017-02-06T16:10:12Z",
|
||||
"side": 1,
|
||||
"message": "let\u0027s let the address function to decide if we need http or https here",
|
||||
"range": {
|
||||
"startLine": 181,
|
||||
"startChar": 8,
|
||||
"endLine": 186,
|
||||
"endChar": 61
|
||||
},
|
||||
"revId": "96316b129a43ee147cd4cd6caa55ac7bb6359882",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a430d35_dcf755f3",
|
||||
"filename": "fuel_ccp_entrypoint/start_script.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 223,
|
||||
"author": {
|
||||
"id": 12039
|
||||
},
|
||||
"writtenOn": "2017-02-06T16:10:12Z",
|
||||
"side": 1,
|
||||
"message": "let\u0027s use list or tuple",
|
||||
"range": {
|
||||
"startLine": 223,
|
||||
"startChar": 4,
|
||||
"endLine": 223,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "96316b129a43ee147cd4cd6caa55ac7bb6359882",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a430d35_1c939da4",
|
||||
"filename": "fuel_ccp_entrypoint/start_script.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 225,
|
||||
"author": {
|
||||
"id": 12039
|
||||
},
|
||||
"writtenOn": "2017-02-06T16:10:12Z",
|
||||
"side": 1,
|
||||
"message": "let\u0027s explicitly define services",
|
||||
"range": {
|
||||
"startLine": 225,
|
||||
"startChar": 9,
|
||||
"endLine": 225,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "96316b129a43ee147cd4cd6caa55ac7bb6359882",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user