x
/
fuel-plugin-calico
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(4 comments)

Patch-set: 1
Reviewer: Gerrit User 16019 <16019@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 16019 2016-01-11 16:23:06 +00:00 committed by Gerrit Code Review
parent 8f4f0fd92a
commit 2710ceb458
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
8f0d8d149bc63d9cad7a83571efa603160697d90
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_d8c8ab57",
"filename": "deployment_scripts/calico-fuel-monitor",
"patchSetId": 1
},
"lineNbr": 35,
"author": {
"id": 16019
},
"writtenOn": "2016-01-11T16:23:06Z",
"side": 1,
"message": "That would involve modifying the list of nodes whilst iterating over it, hence doing it this way.\n\nThis won\u0027t have any effect in the real Fuel system - we\u0027re not writing this back to /etc/hiera/astute.yaml, so it\u0027s just changing the node role in the node list internal to this script. I\u0027ve added a comment to clarify this.",
"parentUuid": "fa69d971_871732ed",
"revId": "8f0d8d149bc63d9cad7a83571efa603160697d90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_a74356ae",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_1885e3cd",
"filename": "deployment_scripts/calico_compute.sh",
"patchSetId": 1
},
"lineNbr": 55,
"author": {
"id": 16019
},
"writtenOn": "2016-01-11T16:23:06Z",
"side": 1,
"message": "Done",
"parentUuid": "fa69d971_a74356ae",
"revId": "8f0d8d149bc63d9cad7a83571efa603160697d90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_a74836b4",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_9871d30e",
"filename": "deployment_scripts/calico_controller.sh",
"patchSetId": 1
},
"lineNbr": 55,
"author": {
"id": 16019
},
"writtenOn": "2016-01-11T16:23:06Z",
"side": 1,
"message": "Done",
"parentUuid": "fa69d971_a74836b4",
"revId": "8f0d8d149bc63d9cad7a83571efa603160697d90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_27b8c674",
@ -68,6 +122,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_98df93d5",
"filename": "deployment_scripts/join_existing_cluster.sh",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 16019
},
"writtenOn": "2016-01-11T16:23:06Z",
"side": 1,
"message": "Correct - thanks for spotting (it was left over from when I was trying to get the dynamic mutation of the etcd cluster on node addition/deletion to work, but is no longer used by anything).",
"parentUuid": "fa69d971_27b8c674",
"revId": "8f0d8d149bc63d9cad7a83571efa603160697d90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_2a7e4d6a",