x/fuel-plugin-lma-collector
Code Issues Proposed changes

Improve collectd http_check plugin logging

Browse Source 
Change-Id: I73316989c440b8b32763d35cecf0647afb275ce1
This commit is contained in:
Swann Croiset
2016-07-29 14:44:20 +02:00
parent d0e18268e5
commit 2f9020f9b2
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
deployment_scripts/puppet/modules/lma_collector/files/collectd/http_check.py
View File

@@ -58,10 +58,13 @@ class HTTPCheckPlugin(base.Base):
yield {'type_instance': name, 'values': self.FAIL}
else:
if r.status_code != self.expected_codes.get(name, 200):
self.logger.warning("{} responded with code {}".format(
url, r.status_code)
)
expected_code = self.expected_codes.get(name, 200)
if r.status_code != expected_code:
self.logger.warning(
("{} ({}) responded with code {} "
"while {} is expected").format(name, url,
r.status_code,
expected_code))
yield {'type_instance': name, 'values': self.FAIL}
else:
self.logger.debug(