x/gantt
Code Issues Proposed changes

Make it easier to add namespaced rpc APIs.

Browse Source 
Add an additional argument to the base create_rpc_dispatcher() method.
When a manager wants to override create_rpc_dispatcher() to add more
callbacks in their own rpc namespaces, it can just call the parent class
with the additional APIs to include.

Change-Id: I9cba8b176b35f55ba9d71365d0a8bf25d2ae311f
This commit is contained in:
Russell Bryant
2013-05-16 11:40:06 -04:00
parent 2a48fe2d73
commit 0a4a6e3b72
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
nova/manager.py
View File

@@ -86,14 +86,18 @@ class Manager(base.Base, periodic_task.PeriodicTasks):
pluginmgr = pluginmanager.PluginManager('nova', self.__class__)
pluginmgr.load_plugins()
def create_rpc_dispatcher(self, backdoor_port=None):
def create_rpc_dispatcher(self, backdoor_port=None, additional_apis=None):
'''Get the rpc dispatcher for this manager.
If a manager would like to set an rpc API version, or support more than
one class as the target of rpc messages, override this method.
'''
apis = []
if additional_apis:
apis.extend(additional_apis)
base_rpc = baserpc.BaseRPCAPI(self.service_name, backdoor_port)
return rpc_dispatcher.RpcDispatcher([self, base_rpc])
apis.extend([self, base_rpc])
return rpc_dispatcher.RpcDispatcher(apis)
def periodic_tasks(self, context, raise_on_error=False):
"""Tasks to be run at a periodic interval."""