x/horizon-mellanox
Code Issues Proposed changes

Update patch set 2

Browse Source 
Patch Set 2: Code-Review-1

(3 comments)

Patch-set: 2
Label: Code-Review=-1
This commit is contained in:
Gerrit User 12171
2016-05-17 17:52:08 +00:00
committed by Gerrit Code Review
parent 00a353114f
commit f1be887bdf
1 changed files with 73 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

73
070be6e274783e4cd976a50f588521f2a91ee2e0 Normal file
View File

@@ -0,0 +1,73 @@
{
"comments": [
{
"key": {
"uuid": "dab17558_68743ace",
"filename": "MANIFEST.in",
"patchSetId": 2
},
"lineNbr": 1,
"author": {
"id": 12171
},
"writtenOn": "2016-05-17T17:52:08Z",
"side": 1,
"message": "why do you need to include the setup.py?",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 1,
"endChar": 16
},
"revId": "070be6e274783e4cd976a50f588521f2a91ee2e0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dab17558_685b9a54",
"filename": "MANIFEST.in",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 12171
},
"writtenOn": "2016-05-17T17:52:08Z",
"side": 1,
"message": "can\u0027t this be on line like recursive-include horizon_mellanox/*",
"range": {
"startLine": 9,
"startChar": 0,
"endLine": 14,
"endChar": 60
},
"revId": "070be6e274783e4cd976a50f588521f2a91ee2e0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dab17558_230a5520",
"filename": "setup.py",
"patchSetId": 2
},
"lineNbr": 31,
"author": {
"id": 12171
},
"writtenOn": "2016-05-17T17:52:08Z",
"side": 1,
"message": "you are using pbr so why this is needed?",
"range": {
"startLine": 30,
"startChar": 4,
"endLine": 31,
"endChar": 30
},
"revId": "070be6e274783e4cd976a50f588521f2a91ee2e0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}