x
/
kolla-mesos
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
This commit is contained in:
Gerrit User 14027 2016-03-24 06:33:17 +00:00 committed by Gerrit Code Review
parent 7df7a4623a
commit b711c0f4bc
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
f19b941dffa55c8a1ce8b5ff8be5115861e1c750
View File

@ -46,6 +46,30 @@
"revId": "f19b941dffa55c8a1ce8b5ff8be5115861e1c750",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa0719c6_6c18dfd3",
"filename": "kolla_mesos/container_scripts/start.py",
"patchSetId": 1
},
"lineNbr": 198,
"author": {
"id": 14027
},
"writtenOn": "2016-03-24T06:33:17Z",
"side": 1,
"message": "Your proposition of using \"decode\" for unicodes would fail like this:\n\n In [7]: u\u0027ąę\u0027.decode(\u0027utf-8\u0027)\n ---------------------------------------------------------------------------\n UnicodeEncodeError Traceback (most recent call last)\n \u003cipython-input-7-aeb814ae3743\u003e in \u003cmodule\u003e()\n ----\u003e 1 u\u0027ąę\u0027.decode(\u0027utf-8\u0027)\n\n /usr/lib64/python2.7/encodings/utf_8.pyc in decode(input, errors)\n 14 \n 15 def decode(input, errors\u003d\u0027strict\u0027):\n ---\u003e 16 return codecs.utf_8_decode(input, errors, True)\n 17 \n 18 class IncrementalEncoder(codecs.IncrementalEncoder):\n\n UnicodeEncodeError: \u0027ascii\u0027 codec can\u0027t encode characters in position 0-1: ordinal not in range(128)",
"parentUuid": "fa0719c6_8c073381",
"range": {
"startLine": 198,
"startChar": 44,
"endLine": 198,
"endChar": 50
},
"revId": "f19b941dffa55c8a1ce8b5ff8be5115861e1c750",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}