Update patch set 16

Patch Set 16: Code-Review-1

(1 comment)

Thanks for the patch! Looks good by and large.

One thing needs another look (comment inline).

Patch-set: 16
Reviewer: Gerrit User 24824 <24824@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

aa598fc57f4899011f766048961f502c48a77879

@@ -0,0 +1,27 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "09fbecfb_0b7eb69e",
+        "filename": "tools/setup-lvm-loopdev/setup-lvm-loopdev",
+        "patchSetId": 16
+      },
+      "lineNbr": 22,
+      "author": {
+        "id": 24824
+      },
+      "writtenOn": "2021-03-17T14:54:48Z",
+      "side": 1,
+      "message": "snapcraft.yaml also contains a setup-lvm-loopdev service so that a loop device is allocated for the backing file after a reboot.\n\nAFAIK there is no guarantee that the same loopback device number will be available after reboot because, for example, other snaps could be installed/removed on this system which would change which devices get allocated to them.\n\nI think we should avoid a filter that\u0027s specific to just one device or, alternatively, force a re-rendering of the LVM config when setup-lvm-loopdev service runs and dynamically allocates a loop device with some number.",
+      "range": {
+        "startLine": 22,
+        "startChar": 0,
+        "endLine": 22,
+        "endChar": 59
+      },
+      "revId": "aa598fc57f4899011f766048961f502c48a77879",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    }
+  ]
+}