Update patch set 12

Patch Set 12: Code-Review-1 (9 comments) Patch-set: 12 Label: Code-Review=-1
2018-02-14 15:37:51 +00:00
parent 2d939051ea
commit 50b2666545
1 changed files with 211 additions and 0 deletions
--- a/211
+++ b/211
@@ -0,0 +1,211 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3fa0c359_2133f363",
+        "filename": ".zuul.yaml",
+        "patchSetId": 12
+      },
+      "lineNbr": 4,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-02-14T15:37:51Z",
+      "side": 1,
+      "message": "Could this name be changed back to openstack-tox-functional?",
+      "range": {
+        "startLine": 4,
+        "startChar": 10,
+        "endLine": 4,
+        "endChar": 44
+      },
+      "revId": "1fe054cd83990e295b691ab711a99bc828b35f0d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa0c359_a14623bf",
+        "filename": ".zuul.yaml",
+        "patchSetId": 12
+      },
+      "lineNbr": 12,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-02-14T15:37:51Z",
+      "side": 1,
+      "message": "ditto",
+      "range": {
+        "startLine": 12,
+        "startChar": 10,
+        "endLine": 12,
+        "endChar": 44
+      },
+      "revId": "1fe054cd83990e295b691ab711a99bc828b35f0d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa0c359_8119a7d7",
+        "filename": ".zuul.yaml",
+        "patchSetId": 12
+      },
+      "lineNbr": 20,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-02-14T15:37:51Z",
+      "side": 1,
+      "message": "ditto",
+      "range": {
+        "startLine": 20,
+        "startChar": 10,
+        "endLine": 20,
+        "endChar": 44
+      },
+      "revId": "1fe054cd83990e295b691ab711a99bc828b35f0d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa0c359_e1dc2be5",
+        "filename": "neutron_classifier/common/constants.py",
+        "patchSetId": 12
+      },
+      "lineNbr": 19,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-02-14T15:37:51Z",
+      "side": 1,
+      "message": "Can someone active on irc grab tmorin and just make sure this is what he meant?\nNot that comfortable putting executable code in the constants module, even less so when it\u0027s not inside a function or class.",
+      "range": {
+        "startLine": 19,
+        "startChar": 15,
+        "endLine": 19,
+        "endChar": 50
+      },
+      "revId": "1fe054cd83990e295b691ab711a99bc828b35f0d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa0c359_e49999c3",
+        "filename": "neutron_classifier/db/migration/alembic_migrations/versions/queens/expand/4e97d48da530_initial_ccf_database_.py",
+        "patchSetId": 12
+      },
+      "lineNbr": 40,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-02-14T15:37:51Z",
+      "side": 1,
+      "message": "Is this meant to be true?",
+      "range": {
+        "startLine": 40,
+        "startChar": 42,
+        "endLine": 40,
+        "endChar": 56
+      },
+      "revId": "1fe054cd83990e295b691ab711a99bc828b35f0d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa0c359_247c6170",
+        "filename": "neutron_classifier/db/models.py",
+        "patchSetId": 12
+      },
+      "lineNbr": 31,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-02-14T15:37:51Z",
+      "side": 1,
+      "message": "This seems to be throwing issues in the functional tests, should this be nullable\u003dFalse? What is it in other neutron extensions?",
+      "range": {
+        "startLine": 31,
+        "startChar": 37,
+        "endLine": 31,
+        "endChar": 52
+      },
+      "revId": "1fe054cd83990e295b691ab711a99bc828b35f0d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa0c359_a4bdd102",
+        "filename": "neutron_classifier/objects/classification_type.py",
+        "patchSetId": 12
+      },
+      "lineNbr": 36,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-02-14T15:37:51Z",
+      "side": 1,
+      "message": "There should probably be a unit test for this to make sure the output is exactly what we expect it to be.",
+      "range": {
+        "startLine": 32,
+        "startChar": 0,
+        "endLine": 36,
+        "endChar": 77
+      },
+      "revId": "1fe054cd83990e295b691ab711a99bc828b35f0d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa0c359_c6b33d97",
+        "filename": "neutron_classifier/objects/classifications.py",
+        "patchSetId": 12
+      },
+      "lineNbr": 36,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-02-14T15:37:51Z",
+      "side": 1,
+      "message": "I think this should be cls, based on the versioned objects test.",
+      "range": {
+        "startLine": 36,
+        "startChar": 12,
+        "endLine": 36,
+        "endChar": 17
+      },
+      "revId": "1fe054cd83990e295b691ab711a99bc828b35f0d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa0c359_243f8187",
+        "filename": "neutron_classifier/objects/classifications.py",
+        "patchSetId": 12
+      },
+      "lineNbr": 45,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-02-14T15:37:51Z",
+      "side": 1,
+      "message": "Does nullable need to be set on these?",
+      "range": {
+        "startLine": 43,
+        "startChar": 47,
+        "endLine": 45,
+        "endChar": 71
+      },
+      "revId": "1fe054cd83990e295b691ab711a99bc828b35f0d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}