x/os-xenapi
Code Issues Proposed changes

os-xenapi: add unit test for himn utils

Browse Source 
Add unit test for himn utils

Change-Id: I5154b5ed3346f8c5d81e117ad09351be4fd7e9ff
This commit is contained in:
naichuans 2017-12-28 08:23:23 +00:00
parent 4cafb55ce0
commit 6059e681f6
3 changed files with 176 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
os_xenapi/client/exception.py
View File

@ -77,3 +77,16 @@ class VdiImportFailure(OsXenApiException):
class VhdDiskTypeNotSupported(OsXenApiException):
msg_fmt = _("Not supported VHD disk type: type=(%(disk_type)s)")
class NoNetworkInterfaceInSameSegment(OsXenApiException):
msg_fmt = _("Can't find network interface in the same network as \
ip=(%(ip)s)")
class ExecuteCommandFailed(OsXenApiException):
msg_fmt = _("Execute command failed: cmd=(%(cmd)s)")
class GetInterfaceOnHIMNMacError(OsXenApiException):
msg_fmt = _("Cannot find eth matches mac: mac=(%(mac)s)")

154
os_xenapi/tests/utils/test_himn.py Normal file
View File

@ -0,0 +1,154 @@
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import netifaces
import mock
from os_xenapi.client import exception
from os_xenapi.tests import base
from os_xenapi.utils import common_function
from os_xenapi.utils import himn
class XenapiHIMNTestCase(base.TestCase):
@mock.patch.object(himn, 'get_local_himn_eth_via_ip')
@mock.patch.object(himn, 'get_local_himn_eth_via_xenstore')
@mock.patch.object(himn, 'persist_eth_cfg')
@mock.patch.object(common_function, 'execute')
def test_config_himn_with_ip_eth(self, mock_execute,
mock_persist_eth,
mock_get_eth_xstore,
mock_get_eth_ip):
fake_eth = 'fake_eth'
mock_get_eth_ip.return_value = fake_eth
fake_himn_ip = 'fake_himn_ip'
himn.config_himn(fake_himn_ip)
mock_get_eth_ip.assert_called_once_with(fake_himn_ip)
mock_persist_eth.assert_called_once_with(fake_eth)
mock_get_eth_xstore.assert_not_called()
@mock.patch.object(himn, 'get_local_himn_eth_via_ip')
@mock.patch.object(himn, 'get_local_himn_eth_via_xenstore')
@mock.patch.object(himn, 'persist_eth_cfg')
@mock.patch.object(common_function, 'execute')
def test_config_himn_with_xenstore_eth(self, mock_execute,
mock_persist_eth,
mock_get_eth_xstore,
mock_get_eth_ip):
fake_eth = 'fake_eth'
mock_get_eth_ip.return_value = None
mock_get_eth_xstore.return_value = fake_eth
fake_himn_ip = 'fake_himn_ip'
himn.config_himn(fake_himn_ip)
mock_get_eth_ip.assert_called_once_with(fake_himn_ip)
mock_persist_eth.assert_called_once_with(fake_eth)
mock_get_eth_xstore.assert_called_once()
@mock.patch.object(himn, 'get_local_himn_eth_via_ip')
@mock.patch.object(himn, 'get_local_himn_eth_via_xenstore')
@mock.patch.object(himn, 'persist_eth_cfg')
def test_config_himn_exception_no_eth(self, mock_persist_eth,
mock_get_eth_xstore,
mock_get_eth_ip):
mock_get_eth_ip.return_value = None
mock_get_eth_xstore.return_value = None
fake_himn_ip = 'fake_himn_ip'
self.assertRaises(exception.NoNetworkInterfaceInSameSegment,
himn.config_himn,
fake_himn_ip)
mock_get_eth_ip.assert_called_once_with(fake_himn_ip)
mock_persist_eth.assert_not_called()
mock_get_eth_xstore.assert_called_once()
@mock.patch.object(common_function, 'execute')
@mock.patch.object(netifaces, 'interfaces')
@mock.patch.object(common_function, 'get_eth_mac')
def test_get_local_himn_eth_via_xenstore(self, mock_get_eth_mac,
mock_nf_interface,
mock_execute):
fake_domid = 'fake_domid'
fake_himn_mac = 'fake_himn_mac'
mock_execute.side_effect = [fake_domid, fake_himn_mac]
expect_call1 = mock.call('xenstore-read', 'domid')
expect_call2 = mock.call(
'xenstore-read',
'/local/domain/%s/vm-data/himn_mac' % fake_domid)
expect_eth = 'fake_hinm_eth'
mock_nf_interface.return_value = ['fake_eth1',
expect_eth,
'fake_eth3']
mock_get_eth_mac.side_effect = ['fake_mac1',
fake_himn_mac,
'fake_mac3']
return_eth = himn.get_local_himn_eth_via_xenstore()
self.assertEqual(return_eth, expect_eth)
mock_execute.assert_has_calls([expect_call1, expect_call2])
mock_nf_interface.assert_called()
mock_get_eth_mac.assert_has_calls([mock.call('fake_eth1'),
mock.call(expect_eth),
mock.call('fake_eth3')])
@mock.patch.object(common_function, 'execute')
@mock.patch.object(netifaces, 'interfaces')
@mock.patch.object(common_function, 'get_eth_mac')
def test_exception_more_than_one_eth(self, mock_get_eth_mac,
mock_nf_interface,
mock_execute):
fake_domid = 'fake_domid'
fake_himn_mac = 'fake_himn_mac'
mock_execute.side_effect = [fake_domid, fake_himn_mac]
expect_call1 = mock.call('xenstore-read', 'domid')
expect_call2 = mock.call(
'xenstore-read',
'/local/domain/%s/vm-data/himn_mac' % fake_domid)
expect_eth = 'fake_hinm_eth'
mock_nf_interface.return_value = ['fake_eth1',
expect_eth,
'fake_eth3']
mock_get_eth_mac.side_effect = ['fake_mac1',
fake_himn_mac,
fake_himn_mac]
self.assertRaises(exception.GetInterfaceOnHIMNMacError,
himn.get_local_himn_eth_via_xenstore)
mock_execute.assert_has_calls([expect_call1, expect_call2])
mock_nf_interface.assert_called()
mock_get_eth_mac.assert_has_calls([mock.call('fake_eth1'),
mock.call(expect_eth),
mock.call('fake_eth3')])
@mock.patch.object(netifaces, 'interfaces')
@mock.patch.object(netifaces, 'ifaddresses')
def test_get_local_himn_eth_via_ip(self, mock_nf_ipadress,
mock_nf_interface):
fake_himn_ip = '169.254.0.1'
mock_nf_interface.return_value = ['eth0', 'eth1']
ipv4_addr = mock.Mock()
ipv4_addr.get.side_effect = [[{'addr': u'10.62.18.16',
'netmask': u'255.255.240.0'}],
[{'addr': u'169.254.0.2',
'netmask': u'255.255.0.0'}]]
mock_nf_ipadress.return_value = ipv4_addr
expect_eth = 'eth1'
expect_calls = [mock.call('eth0'),
mock.call().get(netifaces.AF_INET, []),
mock.call('eth1'),
mock.call().get(netifaces.AF_INET, [])]
return_eth = himn.get_local_himn_eth_via_ip(fake_himn_ip)
self.assertEqual(expect_eth, return_eth)
mock_nf_interface.assert_called_once()
mock_nf_ipadress.assert_has_calls(expect_calls)

14
os_xenapi/utils/himn.py
View File

@ -34,7 +34,7 @@ def get_local_himn_eth_via_xenstore():
eths = [eth for eth in netifaces.interfaces()
if common_function.get_eth_mac(eth) == himn_mac]
if len(eths) != 1:
raise exception('Cannot find eth matches himn_mac')
raise exception.GetInterfaceOnHIMNMacError(himn_mac)
return eths[0]
@ -50,9 +50,12 @@ def get_local_himn_eth_via_ip(ip_in_himn, eths=None):
for eth in eths:
ipv4s = netifaces.ifaddresses(eth).get(netifaces.AF_INET, [])
for ipv4 in ipv4s:
net = ipaddress.ip_network(ipv4['netmask'])
hint_himn_ipaddr = ipaddress.ip_address(unicode(ip_in_himn))
if hint_himn_ipaddr in net:
net_if = ipaddress.IPv4Interface(
ipv4['addr'] + '/' + ipv4['netmask'])
if isinstance(ip_in_himn, bytes):
ip_in_himn = ip_in_himn.decode('utf-8')
hint_himn_ipaddr = ipaddress.ip_address(ip_in_himn)
if hint_himn_ipaddr in net_if.network:
# Got the interface which has an IP address belong to HIMN.
return eth
return None
@ -84,7 +87,7 @@ def config_himn(himn_dom0_ip):
# populate the ifcfg file for HIMN interface, so that it will always get ip
# in the future.
if not eth:
raise exception("can't find eth on %s" % himn_dom0_ip)
raise exception.NoNetworkInterfaceInSameSegment(himn_dom0_ip)
persist_eth_cfg(eth)
# Force a restart on this interface by using the configure file.
# It will ensure the interface up and refresh IP via DHCP.
@ -93,5 +96,6 @@ def config_himn(himn_dom0_ip):
common_function.execute('ifdown', eth)
common_function.execute('ifup', eth)
if __name__ == '__main__':
config_himn(sys.argv[1])