x/packstack
Code Issues Proposed changes

Fixes DHCP firewall protocol

Browse Source 
Sets the firewall rules for DHCP to UDP, also simplified
the rules to allow requests from all hosts

Change-Id: Ia848315112cd53de530f7bf7eb487fce90605e3d
Fixes: rhbz#bug1112019
This commit is contained in:
Ivan Chavero
2014-06-25 07:07:41 -06:00
parent 6d4e5f7a82
commit 5f1d2e86ff
1 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
packstack/plugins/neutron_350.py
View File

@@ -830,23 +830,22 @@ def create_dhcp_manifests(config, messages):
config['CONFIG_NEUTRON_DHCP_INTERFACE_DRIVER'] = get_if_driver(config)
manifest_data = getManifestTemplate("neutron_dhcp.pp")
manifest_file = "%s_neutron.pp" % (host,)
# Firewall Rules
config['FIREWALL_PROTOCOL'] = 'tcp'
for f_host in q_hosts:
config['FIREWALL_ALLOWED'] = "'%s'" % f_host
config['FIREWALL_SERVICE_NAME'] = "neutron dhcp in"
config['FIREWALL_SERVICE_ID'] = ("neutron_dhcp_in_%s_%s"
% (host, f_host))
config['FIREWALL_PORTS'] = "'67'"
config['FIREWALL_CHAIN'] = "INPUT"
manifest_data += getManifestTemplate("firewall.pp")
config['FIREWALL_SERVICE_NAME'] = "neutron dhcp out"
config['FIREWALL_SERVICE_ID'] = ("neutron_dhcp_out_%s_%s"
% (host, f_host))
config['FIREWALL_PORTS'] = "'68'"
config['FIREWALL_CHAIN'] = "OUTPUT"
manifest_data += getManifestTemplate("firewall.pp")
# Firewall Rules for dhcp in
config['FIREWALL_PROTOCOL'] = 'udp'
config['FIREWALL_ALLOWED'] = "'ALL'"
config['FIREWALL_SERVICE_NAME'] = "neutron dhcp in: "
config['FIREWALL_SERVICE_ID'] = "neutron_dhcp_in_%s" % host
config['FIREWALL_PORTS'] = "'67'"
config['FIREWALL_CHAIN'] = "INPUT"
manifest_data += getManifestTemplate("firewall.pp")
# Firewall Rules for dhcp out
config['FIREWALL_PROTOCOL'] = 'udp'
config['FIREWALL_ALLOWED'] = "'ALL'"
config['FIREWALL_SERVICE_NAME'] = "neutron dhcp out: "
config['FIREWALL_SERVICE_ID'] = "neutron_dhcp_out_%s" % host
config['FIREWALL_PORTS'] = "'68'"
config['FIREWALL_CHAIN'] = "OUTPUT"
manifest_data += getManifestTemplate("firewall.pp")
appendManifestFile(manifest_file, manifest_data, 'neutron')