Update patch set 2
Patch Set 2: Code-Review-1 (4 comments) Got few nit's to be addressed before this can be merged. Otherwise, looks good to me. Patch-set: 2 Label: Code-Review=-1
This commit is contained in:
parent
e97f48e489
commit
21e1ec55ed
78
ce64bc5b5c0006550d77281015b0a5d18a350d7e
Normal file
78
ce64bc5b5c0006550d77281015b0a5d18a350d7e
Normal file
@ -0,0 +1,78 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_9388e56b",
|
||||
"filename": "glance-powervc/powervc/glance/manager/manager.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 1336,
|
||||
"author": {
|
||||
"id": 16551
|
||||
},
|
||||
"writtenOn": "2018-07-24T17:17:27Z",
|
||||
"side": 1,
|
||||
"message": "Fix the indentation",
|
||||
"revId": "ce64bc5b5c0006550d77281015b0a5d18a350d7e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_3328f134",
|
||||
"filename": "glance-powervc/powervc/glance/manager/manager.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 1692,
|
||||
"author": {
|
||||
"id": 16551
|
||||
},
|
||||
"writtenOn": "2018-07-24T17:17:27Z",
|
||||
"side": 1,
|
||||
"message": "Isn\u0027t this already moved to the if/else block above?",
|
||||
"range": {
|
||||
"startLine": 1689,
|
||||
"startChar": 0,
|
||||
"endLine": 1692,
|
||||
"endChar": 77
|
||||
},
|
||||
"revId": "ce64bc5b5c0006550d77281015b0a5d18a350d7e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_50256815",
|
||||
"filename": "glance-powervc/powervc/glance/manager/manager.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 2184,
|
||||
"author": {
|
||||
"id": 16551
|
||||
},
|
||||
"writtenOn": "2018-07-24T17:17:27Z",
|
||||
"side": 1,
|
||||
"message": "Fix the indendation",
|
||||
"revId": "ce64bc5b5c0006550d77281015b0a5d18a350d7e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_13b5b5ed",
|
||||
"filename": "glance-powervc/powervc/glance/manager/manager.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 3434,
|
||||
"author": {
|
||||
"id": 16551
|
||||
},
|
||||
"writtenOn": "2018-07-24T17:17:27Z",
|
||||
"side": 1,
|
||||
"message": "Fix the indentation. Also, I think this if/else block can be simplified if you get the pvc_image value in the previous check and use it here.",
|
||||
"revId": "ce64bc5b5c0006550d77281015b0a5d18a350d7e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user