Update patch set 1

Patch Set 1:

(5 comments)

A couple of suggestions.

Patch-set: 1
Label: Verified=0

94b1f96dbd6c4a7bd1a5a167d71ed94433d35f6c

@@ -0,0 +1,89 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "5f201791_350d90e8",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 1
+      },
+      "lineNbr": 7,
+      "author": {
+        "id": 7156
+      },
+      "writtenOn": "2017-06-28T22:46:31Z",
+      "side": 1,
+      "message": "s/instanciate/instantiate/",
+      "revId": "94b1f96dbd6c4a7bd1a5a167d71ed94433d35f6c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f201791_55312ca2",
+        "filename": "almanachclient/http_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 29,
+      "author": {
+        "id": 7156
+      },
+      "writtenOn": "2017-06-28T22:46:31Z",
+      "side": 1,
+      "message": "Why not None as defaults?\n\nYou might want to add support for endpoint_type too. (publicURL, etc.)",
+      "revId": "94b1f96dbd6c4a7bd1a5a167d71ed94433d35f6c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f201791_55d6cc29",
+        "filename": "almanachclient/http_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 32,
+      "author": {
+        "id": 7156
+      },
+      "writtenOn": "2017-06-28T22:46:31Z",
+      "side": 1,
+      "message": "Why not? People with a single region might not provide the region. See other OpenStack clients.",
+      "revId": "94b1f96dbd6c4a7bd1a5a167d71ed94433d35f6c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f201791_b54d20c6",
+        "filename": "almanachclient/http_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 33,
+      "author": {
+        "id": 7156
+      },
+      "writtenOn": "2017-06-28T22:46:31Z",
+      "side": 1,
+      "message": "Is the session only used to query the catalog?\n\nkeystoneauth1 provides a *lot* more to help you develop your own client so you don\u0027t have to reinvent the wheel below by passing headers manually: https://docs.openstack.org/developer/keystoneauth/using-sessions.html#sessions-for-client-developers\n\nMaybe I suggest using it a bit more?",
+      "revId": "94b1f96dbd6c4a7bd1a5a167d71ed94433d35f6c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f201791_35823002",
+        "filename": "almanachclient/http_client.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 37,
+      "author": {
+        "id": 7156
+      },
+      "writtenOn": "2017-06-28T22:46:31Z",
+      "side": 1,
+      "message": "Suppose someone *wants* to override the URL provided by the session and catalog. How can it do it without getting a warning?\n\nThis is the kind of things we (at Internap) do extensively in our setup. May I suggest accepting both session + url. (session for the token/auth handling and url to override the catalog url if needed)",
+      "revId": "94b1f96dbd6c4a7bd1a5a167d71ed94433d35f6c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}