x/python-almanachclient
Code Issues Proposed changes

Update patch set 2

Browse Source 
Patch Set 2: Code-Review-1

(3 comments)

Patch-set: 2
Label: Code-Review=-1
This commit is contained in:
Gerrit User 7156
2017-06-29 18:05:14 +00:00
committed by Gerrit Code Review
parent a94a0b8c00
commit fbab62fa5b
1 changed files with 55 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
88c1eabc473ab557748eaaa9897c400ff5d6af89 Normal file
View File

@@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "3f1d235d_70977b92",
"filename": "almanachclient/http_client.py",
"patchSetId": 2
},
"lineNbr": 42,
"author": {
"id": 7156
},
"writtenOn": "2017-06-29T18:05:14Z",
"side": 1,
"message": "Why not None?",
"revId": "88c1eabc473ab557748eaaa9897c400ff5d6af89",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f1d235d_f036ebb4",
"filename": "almanachclient/http_client.py",
"patchSetId": 2
},
"lineNbr": 45,
"author": {
"id": 7156
},
"writtenOn": "2017-06-29T18:05:14Z",
"side": 1,
"message": "What happens if no session and no endpoint are passed?",
"revId": "88c1eabc473ab557748eaaa9897c400ff5d6af89",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f1d235d_5070ff72",
"filename": "almanachclient/http_client.py",
"patchSetId": 2
},
"lineNbr": 48,
"author": {
"id": 7156
},
"writtenOn": "2017-06-29T18:05:14Z",
"side": 1,
"message": "I think the token could be retrieved from the session too, making token optional too.\n\nOtherwise don\u0027t default it to None. (which I\u0027m suggesting NOT to do please)",
"revId": "88c1eabc473ab557748eaaa9897c400ff5d6af89",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}