x/python-ganttclient
Code Issues Proposed changes

Renamed image_ref variables to image_href. Since the convention is that x_ref

Browse Source 
vars may imply that they are db objects.
This commit is contained in:
Naveed Massjouni
2011-05-25 19:57:04 -04:00
parent 7fd7c2f19c
commit 088664d007
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nova/tests/test_cloud.py
View File

@@ -302,7 +302,7 @@ class CloudTestCase(test.TestCase):
def test_console_output(self):
instance_type = FLAGS.default_instance_type
max_count = 1
kwargs = {'image_ref': 'ami-1',
kwargs = {'image_href': 'ami-1',
'instance_type': instance_type,
'max_count': max_count}
rv = self.cloud.run_instances(self.context, **kwargs)
@@ -318,7 +318,7 @@ class CloudTestCase(test.TestCase):
greenthread.sleep(0.3)
def test_ajax_console(self):
kwargs = {'image_ref': 'ami-1'}
kwargs = {'image_href': 'ami-1'}
rv = self.cloud.run_instances(self.context, **kwargs)
instance_id = rv['instancesSet'][0]['instanceId']
greenthread.sleep(0.3)

6
nova/tests/test_compute.py
View File

@@ -150,7 +150,7 @@ class ComputeTestCase(test.TestCase):
ref = self.compute_api.create(
self.context,
instance_type=instance_types.get_default_instance_type(),
image_ref=None,
image_href=None,
security_group=['testgroup'])
try:
self.assertEqual(len(db.security_group_get_by_instance(
@@ -168,7 +168,7 @@ class ComputeTestCase(test.TestCase):
ref = self.compute_api.create(
self.context,
instance_type=instance_types.get_default_instance_type(),
image_ref=None,
image_href=None,
security_group=['testgroup'])
try:
db.instance_destroy(self.context, ref[0]['id'])
@@ -184,7 +184,7 @@ class ComputeTestCase(test.TestCase):
ref = self.compute_api.create(
self.context,
instance_type=instance_types.get_default_instance_type(),
image_ref=None,
image_href=None,
security_group=['testgroup'])
try: