x/python-ganttclient
Code Issues Proposed changes

Reverse compare arguments in filters tests

Browse Source 
When using assertEqual, the expected result should actually be the first
argument so any failures have 'expected' and 'actual' values printed
properly.

Change-Id: I34d16f298eb0bf62e2abaaf31e80911fa124dc24
This commit is contained in:
Chris Behrens
2013-05-15 08:19:26 +00:00
parent 96958cc922
commit 5787e532f2
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
nova/tests/test_filters.py
View File

@@ -49,7 +49,7 @@ class FiltersTestCase(test.TestCase):
result = base_filter.filter_all(filter_obj_list, filter_properties)
self.assertTrue(inspect.isgenerator(result))
self.assertEqual(list(result), ['obj1', 'obj3'])
self.assertEqual(['obj1', 'obj3'], list(result))
def test_filter_all_recursive_yields(self):
# Test filter_all() allows generators from previous filter_all()s.
@@ -84,7 +84,7 @@ class FiltersTestCase(test.TestCase):
# Pass in generators returned from previous calls.
objs = base_filter.filter_all(objs, filter_properties)
self.assertTrue(inspect.isgenerator(objs))
self.assertEqual(list(objs), ['obj1', 'obj3'])
self.assertEqual(['obj1', 'obj3'], list(objs))
def test_get_filtered_objects(self):
filter_objs_initial = ['initial', 'filter1', 'objects1']
@@ -122,4 +122,4 @@ class FiltersTestCase(test.TestCase):
result = filter_handler.get_filtered_objects(filter_classes,
filter_objs_initial,
filter_properties)
self.assertEqual(result, filter_objs_last)
self.assertEqual(filter_objs_last, result)