
assertNotRaises appears to have been added to provide an easier way to assert that an exception should not be raised by a particular call in the test. However, the implementation has a couple of problems. The first is that it catches every other exception than the one specified, and silently ignores them. This had lead to one bug where a legitimate bug in the test (test_exception_with_rescheduling_enabled) was silently ignored. The call intended to be tested was called with too few arguments and the resulting TypeError was silently ignored. The second is that assertNotRaises could be called with None, which meant that no exceptions should be raised. However, this didn't do anything other than reraise the original exception. Calling assertNotRaises just adds an extra call with no value. From a design stand point, it's not clear what value this assertion provides since the test runner will already fail a test if an exception is raised. Change-Id: I64502dfa0e873f2bbd9b733a5fb63023e1b4e296
OpenStack Nova README
OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of virtualization technologies, including KVM, Xen, LXC, VMWare, and more. In addition to its native API, it includes compatibility with the commonly encountered Amazon EC2 and S3 APIs.
OpenStack Nova is distributed under the terms of the Apache License, Version 2.0. The full terms and conditions of this license are detailed in the LICENSE file.
Nova primarily consists of a set of Python daemons, though it requires and integrates with a number of native system components for databases, messaging and virtualization capabilities.
To keep updated with new developments in the OpenStack project follow @openstack on Twitter.
To learn how to deploy OpenStack Nova, consult the documentation available online at:
In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at:
Developers wishing to work on the OpenStack Nova project should always base their work on the latest Nova code, available from the master GIT repository at:
Developers should also join the discussion on the mailing list, at:
Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests. Further developer focused documentation is available at:
Changes to OpenStack Nova should be submitted for review via the Gerrit tool, following the workflow documented at:
-- End of broadcast