x/python-glareclient
Code Issues Proposed changes

Rename --blob into --file in blob upload

Browse Source 
Change-Id: Id5f01aa0ee4a97d75331b54f7eb9d15f20546237
This commit is contained in:
Mike Fedosin
2016-09-26 15:05:45 +03:00
parent 0a9d7b5b30
commit 46db1d47e8
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
glareclient/osc/v1/blobs.py
View File

@@ -53,9 +53,9 @@ class UploadBlob(command.ShowOne):
help='ID of the artifact to update',
)
parser.add_argument(
'--blob',
'--file',
metavar='<TYPE_NAME>',
help='Local file that contains blob to be uploaded.',
help='Local file that contains data to be uploaded.',
)
parser.add_argument(
'--blob-property',
@@ -76,7 +76,7 @@ class UploadBlob(command.ShowOne):
parsed_args.blob_property = _default_blob_property(
parsed_args.type_name)
blob = utils.get_data_file(parsed_args.blob)
blob = utils.get_data_file(parsed_args.file)
if parsed_args.progress:
file_size = utils.get_file_size(blob)
if file_size is not None:

14
glareclient/tests/unit/osc/v1/test_blob.py
View File

@@ -45,7 +45,7 @@ class TestUploadBlob(TestBlobs):
'art1', '1B', 'active', '0.0.0')
arglist = ['images',
'fc15c365-d4f9-4b8b-a090-d9e230f1f6ba',
'--blob', '/path/to/file']
'--file', '/path/to/file']
verify = [('type_name', 'images')]
parsed_args = self.check_parser(self.cmd, arglist, verify)
@@ -58,7 +58,7 @@ class TestUploadBlob(TestBlobs):
'art1', '1B', 'active', '0.0.0')
arglist = ['tosca_templates',
'fc15c365-d4f9-4b8b-a090-d9e230f1f6ba',
'--blob', '/path/to/file']
'--file', '/path/to/file']
verify = [('type_name', 'tosca_templates')]
parsed_args = self.check_parser(self.cmd, arglist, verify)
@@ -71,7 +71,7 @@ class TestUploadBlob(TestBlobs):
'art1', '1B', 'active', '0.0.0')
arglist = ['heat_templates',
'fc15c365-d4f9-4b8b-a090-d9e230f1f6ba',
'--blob', '/path/to/file']
'--file', '/path/to/file']
verify = [('type_name', 'heat_templates')]
parsed_args = self.check_parser(self.cmd, arglist, verify)
@@ -84,7 +84,7 @@ class TestUploadBlob(TestBlobs):
'art1', '1B', 'active', '0.0.0')
arglist = ['heat_environments',
'fc15c365-d4f9-4b8b-a090-d9e230f1f6ba',
'--blob', '/path/to/file']
'--file', '/path/to/file']
verify = [('type_name', 'heat_environments')]
parsed_args = self.check_parser(self.cmd, arglist, verify)
@@ -97,7 +97,7 @@ class TestUploadBlob(TestBlobs):
'art1', '1B', 'active', '0.0.0')
arglist = ['murano_packages',
'fc15c365-d4f9-4b8b-a090-d9e230f1f6ba',
'--blob', '/path/to/file']
'--file', '/path/to/file']
verify = [('type_name', 'murano_packages')]
parsed_args = self.check_parser(self.cmd, arglist, verify)
@@ -108,7 +108,7 @@ class TestUploadBlob(TestBlobs):
def test_upload_bad(self):
arglist = ['sample_artifact',
'fc15c365-d4f9-4b8b-a090-d9e230f1f6ba',
'--blob', '/path/to/file']
'--file', '/path/to/file']
verify = [('type_name', 'sample_artifact')]
parsed_args = self.check_parser(self.cmd, arglist, verify)
@@ -120,7 +120,7 @@ class TestUploadBlob(TestBlobs):
'art1', '1B', 'active', '0.0.0')
arglist = ['sample_artifact',
'fc15c365-d4f9-4b8b-a090-d9e230f1f6ba',
'--blob', '/path/to/file',
'--file', '/path/to/file',
'--blob-property', 'blob']
verify = [('type_name', 'sample_artifact')]