This patch is meant to address false-positive issues found
by running the bandit static analysis tool. Most of the issues
flagged were false positives, so the 'nosec' keyword has been
added to the instances in order to allow bandit checks to pass.
The one true positive was an except-always condition, which has
been reduced to only continue for IOError cases.
Change-Id: Ib9c51377544ca2dc7789a8eaabf9c432c579e00e
The multi external networks extention allows multiple external networks
to be associated with a single L3Outside.
Change-Id: Iaf3bbc81ffb5e780c53dcedc106d9e20b50ed128
Existing code incorrectly uses the forward slash character for
line continuations. This isn't consistent with upstream conventions,
and is fixed in this patch.
Change-Id: I0c0db5f2105ef0751e3b88d157aeef99acbae6c3
Below are some of the improvements madein this patch for the
Openstack APIC fields in Network, Subnet, Router and Address Scope:
1. Added more descriptive help messages for the apic fields.
2. More user friendly approach to handle dictionary and list elements.
3. Removal of some fields from the set commands.
Change-Id: I50ef5bc56241d0036f2fba3e650c63a7d3539808
The ussuri branch of the pythonclient wasn't working, as the map
needed to be converted back into a list. This patch fixes that.
Change-Id: I04f9a282462081ab7ebe29c9e9c90cb032898d5f
The GBP client CLI was failing, with the following error message:
"Invalid network client version '{'network': '2.0'}'. must be one of: 2.0".
A change in the openstack SDK (>=18.0) was causing this failure in the
upstream neutron python client, which was resolved with this commit:
https://review.opendev.org/#/c/615184/
This commit makes a similar fix for the GBP python client.
Change-Id: I660c6881ef406a6d9995e2712399a3ac06ba207a
* Removed py36 env from 'tox.ini'.
* Updated requirements.txt with relevant 'stable/rocky' branch
libraries.
* Updated test-requirements.txt with relevant 'stable/rocky' branch
libraries.
* Replaced 'mox' with 'mock' on unit tests.
* Use stestr directly instead of ostestr to run UTs, as is done in
newer upstream branches.
* Specify basepython as python2.7 for pep8, cover jobs, in case a
python3 version of tox is used.
* Added 'flake8-import-order' and kept import-order-style as 'pep8'.
* Added zuul jobs w.r.t. 'stable/rocky' release.
* Removed '-U' option from toxenv install command, for stable/rocky
& above branches compatibility.
Change-Id: I9161749fb2d8618b695815c095bdedae0251bb76
* dict_items, dict_values, dict_keys returns view in Py3 instead of
list so wrapped with list.
* Replaced dict.iteritems() with dict.items().
* Replaced dict.itervalues() with dict.values().
* Replaced 'unicode(err)' with
'oslo_utils.encodeutils.exception_to_unicode(err)'.
* Added 'openstack-tox-py35' in Zuul CI jobs.
Fixes bug 1877507
Change-Id: Ic0892bfd501bc45bb8b7b7bebe299c86c34710ae
This is to work around an issue that a broken pipe exception
might get thrown when we invoke this purge through neutron
client API. We don't have this issue when its invoked thru
CLI.
Change-Id: I94d6ab8658efc08dd5be8dbd348e098453e71b39
The current order breaks on Ubuntu.
Change-Id: I057d19a9a146bb09b7c639f656760a86d765bd74
(cherry picked from commit 1983462134f824890a6cc355fb7b6f2d94cce032)
