x/stackalytics
Code Issues Proposed changes

Fix the invalid change-id ext-link url

Browse Source 
Change-Id: Ie1284b4b83b17cc37c956130487b0deb016f7a24
Closes-Bug: #1728521
This commit is contained in:
Guoqiang Ding 2017-10-30 15:03:59 +08:00
parent 10c8635f36
commit 088cd904ec
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
stackalytics/dashboard/helpers.py
View File

@ -308,7 +308,7 @@ def make_commit_message(record):
r'\1<a href="https://bugs.launchpad.net/bugs/\2" '
r'class="ext_link">\2</a>', s)
s = re.sub(r'\s+(I[0-9a-f]{40})',
r' <a href="https://review.openstack.org/#q,\1,n,z" '
r' <a href="https://review.openstack.org/#/q/\1" '
r'class="ext_link">\1</a>', s)
s = utils.unwrap_text(s)

8
stackalytics/tests/unit/test_web_utils.py
View File

@ -46,8 +46,8 @@ returned.
Fixes bug <a href="https://bugs.launchpad.net/bugs/1076801" class="ext_link">\
1076801</a>
''' + (
'Change-Id: <a href="https://review.openstack.org/#q,'
'Ie49ccd2138905e178843b375a9b16c3fe572d1db,n,z" class="ext_link">'
'Change-Id: <a href="https://review.openstack.org/#/q/'
'Ie49ccd2138905e178843b375a9b16c3fe572d1db" class="ext_link">'
'Ie49ccd2138905e178843b375a9b16c3fe572d1db</a>')
observed = helpers.make_commit_message(record)
@ -73,8 +73,8 @@ Implemented new driver for Cinder &lt;:
Implements Blueprint ''' + (
'<a href="https://blueprints.launchpad.net/cinder/+spec/'
'super-driver" class="ext_link">super-driver</a>' + '\n' +
'Change-Id: <a href="https://review.openstack.org/#q,'
'Ie49ccd2138905e178843b375a9b16c3fe572d1db,n,z" class="ext_link">'
'Change-Id: <a href="https://review.openstack.org/#/q/'
'Ie49ccd2138905e178843b375a9b16c3fe572d1db" class="ext_link">'
'Ie49ccd2138905e178843b375a9b16c3fe572d1db</a>')
observed = helpers.make_commit_message(record)