x/stackalytics
Code Issues Proposed changes

Remove unused parameters in _normalize_user()

Browse Source 
_normalize_user() passes multiple parameters into make_user_id() call.
However parts of them are not used in make_user_id() because "emails"
is mandatory on the default data on its json-schema definition and
make_user_id() considers launchpad_id and emails as user_id before
checking these parameters.
So this patch removes such unused parameters for the cleanup.

Change-Id: I09070ceb226f9ea1b45c36a24c492cac4e606be2
This commit is contained in:
Ken'ichi Ohmichi
2017-06-12 15:30:26 -07:00
parent fa0eaf06a1
commit fa899f0e23
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
stackalytics/processor/normalizer.py
View File

@@ -39,11 +39,7 @@ def _normalize_user(user):
end_date=0))
user['user_id'] = user_processor.make_user_id(
launchpad_id=user.get('launchpad_id'),
emails=user.get('emails'),
gerrit_id=user.get('gerrit_id'),
github_id=user.get('github_id'),
zanata_id=user.get('zanata_id'),
ldap_id=user.get('ldap_id')) or user.get('user_id')
emails=user.get('emails'))
def _normalize_users(users):