Update patch set 5
Patch Set 5: Code-Review-1 (2 comments) Steve, this is an excellent start and I'd actually support approving this and iterating over it. I did add a request, however, to the Core Reviewer section that I'd like to see added before this gets merged. Please let me know your thoughts! Best, -jay Patch-set: 5 Label: Code-Review=-1
This commit is contained in:
committed by
Gerrit Code Review
parent
c8324af5b9
commit
a976162b1f
@@ -1,5 +1,22 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3afb71cf_cd3521f8",
|
||||
"filename": "doc/source/workflow.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 75,
|
||||
"author": {
|
||||
"id": 7
|
||||
},
|
||||
"writtenOn": "2015-06-04T20:53:05Z",
|
||||
"side": 1,
|
||||
"message": "This last line is too complicated. Just do this instead:\n\n git review",
|
||||
"revId": "3f4f1cfe6a620890b1260517b196bc925b2b80e5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9a0c5dc1_a0cf397e",
|
||||
@@ -17,6 +34,23 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3afb71cf_f84c1978",
|
||||
"filename": "doc/source/workflow.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 93,
|
||||
"author": {
|
||||
"id": 7
|
||||
},
|
||||
"writtenOn": "2015-06-04T20:53:05Z",
|
||||
"side": 1,
|
||||
"message": "I would also add something here about having a core reviewer in *all* affected projects provide a review on the telcowg-spec before being approved by a core reviewer. One of the big points of the Telco working group is improving collaboration between the Telco SMEs and the developers that ultimately will be coding the work items in the various OpenStack projects. Socializing various TelcoWG specs with the core review teams of the OpenStack projects is an important first step to achieving that collaborative effect.",
|
||||
"revId": "3f4f1cfe6a620890b1260517b196bc925b2b80e5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9a0c5dc1_008cc533",
|
||||
|
||||
Reference in New Issue
Block a user