x/tobiko
Code Issues Proposed changes

Check it gets something from stderr before handling ping errors

Browse Source 
Change-Id: I0527c3f3ba110f021c2b724e0102bbd034d06f55
This commit is contained in:
Federico Ressi 2019-04-11 12:48:57 +02:00
parent 3209a04152
commit 280f5d8367
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tobiko/shell/ping/_ping.py
View File

@ -219,7 +219,8 @@ def execute_ping(parameters, ssh_client=None, check=True, **params):
command = get_ping_command(parameters) command = get_ping_command(parameters)
result = sh.execute(command=command, ssh_client=ssh_client, result = sh.execute(command=command, ssh_client=ssh_client,
timeout=parameters.timeout, check=False) timeout=parameters.timeout, check=False)
if check and result.exit_status:
if check and result.exit_status and result.stderr:
handle_ping_command_error(error=result.stderr) handle_ping_command_error(error=result.stderr)
return result return result