x/tobiko
Code Issues Proposed changes

Reduce test_ping_subnet_gateways duration when it fails

Browse Source 
Due to the different retries mechanisms, these test was taking hours
when VM instances were not reachable due to any problem, causing tobiko
execution timeout

Change-Id: Ibc3767d9563982f462f1ec9900029d49c3eee0d3
This commit is contained in:
Eduardo Olivares 2020-10-15 21:07:05 +02:00
parent 4102a2e452
commit 2d8a8ec41d
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tobiko/shell/ping/_interface.py
View File

@ -89,8 +89,8 @@ def get_ping_usage(ssh_client):
if usage:
LOG.debug('Got ping usage text')
else:
LOG.warning("Unable to get usage message from ping command:\n"
"%s", result.details)
raise ValueError("Unable to get usage message from ping command:\n"
"%s" % result.details)
return usage

2
tobiko/shell/ssh/config.py
View File

@ -61,7 +61,7 @@ OPTIONS = [
help=("Minimal seconds to wait between every "
"failed SSH connection attempt")),
cfg.IntOpt('connection_timeout',
default=600.,
default=200.,
help=("Time before stopping retrying establishing an SSH "
"connection")),
cfg.StrOpt('proxy_jump',

1
tobiko/tests/scenario/neutron/test_port.py
View File

@ -46,7 +46,6 @@ class PortTest(testtools.TestCase):
network_subnets = self.stack.network_stack.network_details['subnets']
self.assertEqual(set(network_subnets), set(port_subnets))
@tobiko.retry_test_case(interval=30.)
def test_ping_subnet_gateways(self):
network_id = self.stack.network_stack.network_id
subnets = neutron.list_subnets(network_id=network_id)