Add Designate Client unit tests

Remove overlapping functional test for zone ID

Change-Id: I14d89506cc2e8f4d91ef66e48ac74aa38fa1709e

tobiko/tests/functional/openstack/test_designate.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2019 Red Hat, Inc.
+# Copyright (c) 2022 Red Hat, Inc.
 #
 # All Rights Reserved.
 #
@@ -41,9 +41,3 @@ class DesignateClientTest(testtools.TestCase):
         self.assertEqual(zone['id'], self.stack.zone_id)
         self.assertEqual(zone['name'], self.stack.zone_name)
         self.assertEqual(zone, self.stack.zone_details)
-
-    def test_designate_zone_id(self):
-        self.assertEqual('some-id',
-                         designate.designate_zone_id('some-id'))
-        self.assertEqual('some-id',
-                         designate.designate_zone_id({'id': 'some-id'}))

tobiko/tests/unit/openstack/designate/test_client.py

@@ -0,0 +1,68 @@
+# Copyright 2022 Red Hat
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+from __future__ import absolute_import
+
+from tobiko.openstack import designate
+from tobiko.openstack import keystone
+from tobiko.tests.unit import openstack
+from tobiko.tests.unit.openstack import test_client
+
+
+class DesignateClientFixtureTest(test_client.OpenstackClientFixtureTest):
+
+    def create_client(self, session=None):
+        return designate.DesignateClientFixture(session=session)
+
+
+class GetDesignatelientTest(openstack.OpenstackTest):
+
+    def test_get_designate_client(self, session=None, shared=True):
+        client1 = designate.get_designate_client(session=session,
+                                                 shared=shared)
+        client2 = designate.get_designate_client(session=session,
+                                                 shared=shared)
+        if shared:
+            self.assertIs(client1, client2)
+        else:
+            self.assertIsNot(client1, client2)
+        self.assertIsInstance(client1, designate.DESIGNATE_CLIENT_CLASSES)
+        self.assertIsInstance(client2, designate.DESIGNATE_CLIENT_CLASSES)
+
+    def test_get_designate_client_with_not_shared(self):
+        self.test_get_designate_client(shared=False)
+
+    def test_get_designate_client_with_session(self):
+        session = keystone.get_keystone_session()
+        self.test_get_designate_client(session=session)
+
+
+class DesignateClientTest(openstack.OpenstackTest):
+
+    def test_designate_client_with_none(self):
+        default_client = designate.get_designate_client()
+        client = designate.designate_client(None)
+        self.assertIsInstance(client, designate.DESIGNATE_CLIENT_CLASSES)
+        self.assertIs(default_client, client)
+
+    def test_designate_client_with_client(self):
+        default_client = designate.get_designate_client()
+        client = designate.designate_client(default_client)
+        self.assertIsInstance(client, designate.DESIGNATE_CLIENT_CLASSES)
+        self.assertIs(default_client, client)
+
+    def test_designate_client_with_fixture(self):
+        fixture = designate.DesignateClientFixture()
+        client = designate.designate_client(fixture)
+        self.assertIsInstance(client, designate.DESIGNATE_CLIENT_CLASSES)
+        self.assertIs(client, fixture.client)

tobiko/tests/unit/openstack/designate/test_zone.py

@@ -0,0 +1,28 @@
+# Copyright 2022 Red Hat
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+from __future__ import absolute_import
+
+from tobiko.openstack import designate
+from tobiko.tests.unit import openstack
+
+
+class DesignateZoneTest(openstack.OpenstackTest):
+
+    def test_designate_zone_id_with_str(self):
+        self.assertEqual('some-id',
+                         designate.designate_zone_id('some-id'))
+
+    def test_designate_zone_id_with_dict(self):
+        self.assertEqual('some-id',
+                         designate.designate_zone_id({'id': 'some-id'}))