x/tobiko
Code Issues Proposed changes

Write to log the begin and the end of every test case.

Browse Source 
Change-Id: Id5b07b30be076929cb8d82b5892a0ea71ce57c7f
This commit is contained in:
Federico Ressi 2019-09-26 17:24:37 +02:00
parent 798a175ac9
commit 91964b910a
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tobiko/common/_logging.py
View File

@ -33,8 +33,9 @@ class CaptureLogFixture(_fixture.SharedFixture):
logger = logging.root logger = logging.root
handler = None handler = None
def __init__(self, logger=None, level=None): def __init__(self, test_case_id, logger=None, level=None):
super(CaptureLogFixture, self).__init__() super(CaptureLogFixture, self).__init__()
self.test_case_id = test_case_id
if logger: if logger:
self.logger = logger self.logger = logger
if level: if level:
@ -42,8 +43,10 @@ class CaptureLogFixture(_fixture.SharedFixture):
def setup_fixture(self): def setup_fixture(self):
self.handler = handler = CaptureLogHandler(level=self.level) self.handler = handler = CaptureLogHandler(level=self.level)
self.logger.addHandler(handler)
self.addCleanup(self.logger.removeHandler, handler) self.addCleanup(self.logger.removeHandler, handler)
self.logger.addHandler(handler)
LOG.debug('--- BEGIN %s ---', self.test_case_id)
self.addCleanup(LOG.debug, '--- END %s ---', self.test_case_id)
def getDetails(self): def getDetails(self):
handler = self.handler handler = self.handler
@ -84,6 +87,7 @@ class CaptureLogTest(testtools.TestCase):
capture_log_logger = logging.root capture_log_logger = logging.root
def setUp(self): def setUp(self):
self.useFixture(CaptureLogFixture(level=self.capture_log_level, self.useFixture(CaptureLogFixture(test_case_id=self.id(),
level=self.capture_log_level,
logger=self.capture_log_logger)) logger=self.capture_log_logger))
super(CaptureLogTest, self).setUp() super(CaptureLogTest, self).setUp()

6
tobiko/tests/unit/test_logging.py
View File

@ -26,7 +26,7 @@ LOG = log.getLogger(__name__)
class CapureLogTest(unit.TobikoUnitTest): class CapureLogTest(unit.TobikoUnitTest):
def test_capture_log_content(self): def test_capture_log_content(self):
with tobiko.CaptureLogFixture() as capture: with tobiko.CaptureLogFixture(test_case_id=self.id()) as capture:
LOG.warning('Some debug line') LOG.warning('Some debug line')
content = capture.getDetails()['log'] logged_lines = capture.getDetails()['log'].as_text().splitlines()
self.assertEqual('Some debug line\n', content.as_text()) self.assertIn('Some debug line', logged_lines)