x/tobiko
Code Issues Proposed changes

Remove test_ovs module from the faults tests for neutron

Browse Source 
This module contained only one test "test_recreate_physical_bridge"
which was deleting physical bridges from the controller node, creating
those bridges again and ensuring that neutron-ovs-agent did
reconfiguration of that physical bridges properly and connectivity
through the bridges is restored.
Problem with this test is that it is "too much" intrusive. Physical
bridge needs to have some physical interface added to it to have
connectivity to the physical network. When bridge is deleted, such
port from the bridge is gone too. And Tobiko was adding bridge again,
but it wasn't adding interfaces again at all. That caused problems with
connectivity of the FIPs as well as some other stuff, like access to the
rabbitmq for services on that node when the same bridge was used for the
control plane networks.
The problem is that it would be very hard for tobiko to restore all the
configuration of the bridges as it can be some vlan interace (like
vlan50 in many Tripleo based virtual deployments used in CI), some
physical NIC or patch port to other bridge (like to br-infra in the u/s
CI configurations).

Taking all of that into account I think that it's better to simply
remove that test which in fact don't have that much value and make
Tobiko test suite more stable in testing other stuff.

Change-Id: I1f87cd74936809fe391cd8841d29ece46f9c7afe
This commit is contained in:
Slawek Kaplonski 2022-09-02 14:40:58 +02:00
parent 72c7716de4
commit a5f3cbeb83
1 changed files with 0 additions and 93 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

93
tobiko/tests/faults/neutron/test_ovs.py
View File

@ -1,93 +0,0 @@
# Copyright (c) 2020 Red Hat
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from __future__ import absolute_import
import collections
import testtools
import tobiko
from tobiko.openstack import neutron
from tobiko.openstack import stacks
from tobiko.openstack import topology
from tobiko.shell import ping
from tobiko.shell import sh
from tobiko.tripleo import undercloud
@neutron.skip_if_missing_networking_agents(neutron.OPENVSWITCH_AGENT)
@neutron.skip_if_missing_networking_agents(neutron.L3_AGENT)
class OpenvswitchTest(testtools.TestCase):
stack = tobiko.required_fixture(stacks.CirrosServerStackFixture)
def setUp(self):
super(OpenvswitchTest, self).setUp()
self.ovs_agents = neutron.list_agents(agent_type="Open vSwitch agent")
self.router_id = self.stack.network_stack.gateway_id
self.deleted_bridges = collections.defaultdict(set)
def tearDown(self):
super(OpenvswitchTest, self).tearDown()
# Try to create all bridges which were deleted during the tests
self._create_bridges()
def _create_bridges(self):
for host, bridges in self.deleted_bridges.items():
self._create_bridge(host, bridges)
def _create_bridge(self, hostname, bridges):
for br_name in bridges:
agent_host = topology.get_openstack_node(hostname=hostname)
sh.execute(
"sudo ovs-vsctl --may-exist add-br %s" % br_name,
ssh_client=agent_host.ssh_client)
def _delete_bridges(self, hostname, bridges):
for br_name in bridges:
agent_host = topology.get_openstack_node(hostname=hostname)
sh.execute(
"sudo ovs-vsctl del-br %s" % br_name,
ssh_client=agent_host.ssh_client)
self.deleted_bridges[hostname].add(br_name)
def _get_agent_from_host(self, hostname):
host_shortname = tobiko.get_short_hostname(hostname)
for agent in self.ovs_agents:
if host_shortname == tobiko.get_short_hostname(agent['host']):
return agent
raise neutron.AgentNotFoundOnHost(agent_type="neutron-ovs-agent",
host=hostname)
@stacks.NetworkStackFixture.skip_if_router_is_distributed()
@undercloud.skip_if_missing_undercloud
def test_recreate_physical_bridge(self):
# Check if vm is reachable before test
ip_add = self.stack.ip_address
ping.ping_until_received(ip_add).assert_replied()
network_l3_agents = neutron.list_l3_agent_hosting_routers(
self.router_id)
for agent in network_l3_agents:
# Get neutron-ovs-agent bridge mappings
ovs_agent = self._get_agent_from_host(agent['host'])
self._delete_bridges(
agent['host'],
ovs_agent['configurations']['bridge_mappings'].values())
ping.ping_until_unreceived(ip_add).assert_not_replied()
self._create_bridges()
ping.ping_until_received(ip_add).assert_replied()