x/tobiko
Code Issues Proposed changes

Merge "Run ping with interval option only when the ping interface supports it"

Browse Source
This commit is contained in:
Zuul
2025-06-04 10:05:42 +00:00
committed by Gerrit Code Review
parent 6e38a2a813 46a7150d86
commit e69cc1bde5
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tobiko/shell/ping/_interface.py
View File

@@ -172,7 +172,11 @@ class PingInterface(object):
interval = parameters.interval
if interval > 1:
options += self.get_interval_option(interval)
if self.has_interval_option:
options += self.get_interval_option(interval)
else:
LOG.warning(f'Interval option with value {interval} ignored '
f'because not supported by ping interface {self}')
fragment = parameters.fragmentation
if fragment is not None:
@@ -199,8 +203,12 @@ class PingInterface(object):
def get_size_option(self, size):
return ['-s', int(size)]
has_interval_option = False
def get_interval_option(self, interval):
return ['-i', int(interval)]
details = ("{!r} ping implementation doesn't support "
"'interval={!r}' option").format(self, interval)
raise _exception.UnsupportedPingOption(details=details)
has_fragment_option = False
@@ -238,6 +246,11 @@ class IpUtilsPingInterface(PingInterface):
def match_ping_usage(self, usage):
return usage.startswith(IPUTILS_PING_USAGE)
has_interval_option = True
def get_interval_option(self, interval):
return ['-i', int(interval)]
has_fragment_option = True
def get_fragment_option(self, fragment):