x/valence-specs
Code Issues Proposed changes

Update patch set 3

Browse Source 
Patch Set 3: Code-Review-1

(4 comments)

Overall looks good. Just a couple of minor queries/suggestions.

Patch-set: 3
Reviewer: Gerrit User 22714 <22714@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 22714
2017-06-27 05:27:42 +00:00
committed by Gerrit Code Review
parent 73b5fd72fd
commit e6d8d83380
1 changed files with 90 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
9195a4b2809ad11fa01584f296671ece2565d382 Normal file
View File

@@ -0,0 +1,90 @@
{
"comments": [
{
"key": {
"uuid": "5f201791_20d8fa1b",
"filename": "specs/pike/approved/vendor_extensible_framework.rst",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 22714
},
"writtenOn": "2017-06-27T05:27:42Z",
"side": 1,
"message": "spec :)",
"range": {
"startLine": 13,
"startChar": 5,
"endLine": 13,
"endChar": 14
},
"revId": "9195a4b2809ad11fa01584f296671ece2565d382",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f201791_a00bea7a",
"filename": "specs/pike/approved/vendor_extensible_framework.rst",
"patchSetId": 3
},
"lineNbr": 22,
"author": {
"id": 22714
},
"writtenOn": "2017-06-27T05:27:42Z",
"side": 1,
"message": "I suggest we call out \"non-Redfish composable/disaggregated hardware\".",
"range": {
"startLine": 22,
"startChar": 4,
"endLine": 22,
"endChar": 9
},
"revId": "9195a4b2809ad11fa01584f296671ece2565d382",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f201791_e07a02ef",
"filename": "specs/pike/approved/vendor_extensible_framework.rst",
"patchSetId": 3
},
"lineNbr": 36,
"author": {
"id": 22714
},
"writtenOn": "2017-06-27T05:27:42Z",
"side": 1,
"message": "\u0027P\u0027 in caps might be a better formatting.",
"revId": "9195a4b2809ad11fa01584f296671ece2565d382",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f201791_a059aa8e",
"filename": "specs/pike/approved/vendor_extensible_framework.rst",
"patchSetId": 3
},
"lineNbr": 39,
"author": {
"id": 22714
},
"writtenOn": "2017-06-27T05:27:42Z",
"side": 1,
"message": "Did you mean \"instantiates a PODM object based on Redfish\"?",
"range": {
"startLine": 39,
"startChar": 13,
"endLine": 39,
"endChar": 58
},
"revId": "9195a4b2809ad11fa01584f296671ece2565d382",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}