x/vmware-nsx
Code Issues Proposed changes

NSXV3: harden subnet creation for external networks

Browse Source 
A external network subnet should not have DHCP enabled. When
creating the external network we ensure that the binding will be
created. This ensures that the subnet validations are done
correctly.

Change-Id: I036740736445550d9e08580a90a97ca147619222
This commit is contained in:
Gary Kotton
2017-05-28 05:01:42 -07:00
committed by Adit Sarfaty
parent 9613a519b9
commit 305d75d8fb
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
vmware_nsx/plugins/nsx_v3/plugin.py
View File

@@ -691,14 +691,12 @@ class NsxV3Plugin(agentschedulers_db.AZDhcpAgentSchedulerDbMixin,
return tier0_info['edge_cluster_uuid']
def _validate_external_net_create(self, net_data):
is_provider_net = False
if not validators.is_attr_set(net_data.get(pnet.PHYSICAL_NETWORK)):
tier0_uuid = self._default_tier0_router
else:
tier0_uuid = net_data[pnet.PHYSICAL_NETWORK]
is_provider_net = True
self._routerlib.validate_tier0(self.tier0_groups_dict, tier0_uuid)
return (is_provider_net, utils.NetworkTypes.L3_EXT, tier0_uuid, 0)
return (True, utils.NetworkTypes.L3_EXT, tier0_uuid, 0)
def _create_network_at_the_backend(self, context, net_data, az):
is_provider_net, net_type, physical_net, vlan_id = (