x/vmware-nsx
Code Issues Proposed changes

Fix OSC tests to support newer release

Browse Source 
Change-Id: I80acac39a6d505c4e25d0bc021c9463177f251b1
This commit is contained in:
asarfaty 2021-03-21 11:05:59 +02:00
parent 02c6203e32
commit db86f5d85c
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
vmware_nsx/tests/unit/osc/v2/test_port.py
View File

@ -73,7 +73,7 @@ class TestCreatePort(test_port.TestCreatePort):
ref_columns, ref_data = self._get_common_cols_data(self._port)
self.assertEqual(ref_columns, columns)
self.assertItemEqual(ref_data, data)
self.assertItemsEqual(ref_data, data)
def _test_create_with_vnix_index(self, val, is_valid=True):
self._test_create_with_arg_and_val('vnic_index', val, is_valid)
@ -112,7 +112,7 @@ class TestCreatePort(test_port.TestCreatePort):
ref_columns, ref_data = self._get_common_cols_data(self._port)
self.assertEqual(ref_columns, columns)
self.assertItemEqual(ref_data, data)
self.assertItemsEqual(ref_data, data)
def test_create_with_provider_security_groups(self):
# create a port with few provider security groups
@ -144,7 +144,7 @@ class TestCreatePort(test_port.TestCreatePort):
ref_columns, ref_data = self._get_common_cols_data(self._port)
self.assertEqual(ref_columns, columns)
self.assertItemEqual(ref_data, data)
self.assertItemsEqual(ref_data, data)
def test_create_with_provider_security_group_by_name(self):
# create a port with 1 provider security group
@ -174,7 +174,7 @@ class TestCreatePort(test_port.TestCreatePort):
ref_columns, ref_data = self._get_common_cols_data(self._port)
self.assertEqual(ref_columns, columns)
self.assertItemEqual(ref_data, data)
self.assertItemsEqual(ref_data, data)
def _test_create_with_flag_arg(
self, arg_name, validate_name, validate_val):
@ -204,7 +204,7 @@ class TestCreatePort(test_port.TestCreatePort):
ref_columns, ref_data = self._get_common_cols_data(self._port)
self.assertEqual(ref_columns, columns)
self.assertItemEqual(ref_data, data)
self.assertItemsEqual(ref_data, data)
def test_create_with_mac_learning(self):
self._test_create_with_flag_arg(

2
vmware_nsx/tests/unit/osc/v2/test_router.py
View File

@ -66,7 +66,7 @@ class TestCreateRouter(test_router.TestCreateRouter):
})
self.assertEqual(self.columns, columns)
self.assertItemEqual(self.data, data)
self.assertItemsEqual(self.data, data)
def _test_create_with_size(self, size, is_valid=True):
self._test_create_with_arg_and_val('router_size', size, is_valid)

4
vmware_nsx/tests/unit/osc/v2/test_security_group.py
View File

@ -70,7 +70,7 @@ class TestCreateSecurityGroup(
validate_name: validate_val,
})
self.assertEqual(self.columns, columns)
self.assertItemEqual(self.data, data)
self.assertItemsEqual(self.data, data)
def test_create_with_logging(self):
self._test_create_with_flag_arg('logging', 'logging', True)
@ -107,7 +107,7 @@ class TestCreateSecurityGroup(
arg_name: arg_val,
})
self.assertEqual(self.columns, columns)
self.assertItemEqual(self.data, data)
self.assertItemsEqual(self.data, data)
def test_create_with_policy(self):
self._test_create_with_arg_val('policy', 'policy-1')

2
vmware_nsx/tests/unit/osc/v2/test_subnet.py
View File

@ -72,7 +72,7 @@ class TestCreateSubnet(test_subnet.TestCreateSubnet):
})
self.assertEqual(self.columns, columns)
self.assertItemEqual(self.data, data)
self.assertItemsEqual(self.data, data)
def _test_create_with_tag(self, add_tags=True):
self.skipTest('Unblock gate')