Remove tox_install.sh, we have now all dependencies in
global-requirements and don't need this setup anymore.
Update tox.ini for this, move constraints into deps for proper
working.
This enables proper installation of dependencies from git.
Depends-On: https://review.openstack.org/552865
Depends-On: https://review.openstack.org/554297
Change-Id: I49d432bdf01221d0244449c4e2be807d0f646afa
Move neutron to requirements.txt Since neutron is now in
global-requirements, we can remove the installation from
tools/tox_install.sh.
Change-Id: I3d5aa6d61d1601358f6972a606c5a0a6fb5c2dd0
ostestr is no longer installed by default by infra and will be totally
removed longer term; stestr [1] is its replacement.
This is the reason out gate is failing with the following today:
nsx/tools/ostestr_compat_shim.sh: ostestr: not found
This patch moves us to stestr by:
- Updating tox.ini to use stestr rather than call ostestr_compat_shim.sh
and in turn ostestr.
- Removing ostestr_compat_shim.sh as its no longer used.
For more details on stestr see [1].
Also note that this is a quick migration to stestr to get the gate
working; additional tweaks may come up.
[1] http://stestr.readthedocs.io/en/latest/MANUAL.html
Change-Id: I9a871d3542c2f2615d757c0009ea3d6695f0e3f7
This patch updates our tox_install_project.sh script to account for zuul
v3 changes. The changes are made to be backwards compatible so the
script should also still work with zuul v2 jobs. Also see the depends on
patch for the project-config changes needed for our zuul v3 support.
Depends-On: Icd0dfdef3486be95ef45beb9ea96767f731d9e9e
Change-Id: Ic0d25e9f9e6d1fe7cba7cae93e66dbbc08c12071
This now existsin the vmware_nsx_tempest_plugin
Change-Id: I76e5856deeeb06b87675314635d06aa0291143eb
Depends-On: I804c3fd1e0c9cbeb454677e7951072ad74391fec
This change implement's a new BGP plugin which allows BGP support in Openstack,
using NSXv service edges (ESG).
When a BGP speaker is associated with an external network, service edges which
accommodates tenant routers that have their GW port on this network would be
configured to enable BGP/Dynamic-routing.
The specific BGP configuration (e.g - localAS, neighbours) for the edge is
retrieved from the BGP speaker object and its peers.
This change also adds an extension to the BGP peer object, this
extension allows the cloud operator to associate a BGP peer with a specific
service edge that will serve as GW edge for the network, multiple GW
edges are supported by enabling ECMP on tenant service edges.
Co-Authored: yuyangbj <yangyu@vmware.com>
Change-Id: Ife69b97f3232bee378a48d91dc53bdc8837de7f5
The nsx-v FWaaS driver will add the configured firewall rules to
the router edges.
Currently there is not support for shared routers.
The rules will be edded after the current rules (NAT, LBaaS, external traffic)
for exclusive routers edges and distributed routers PLR edged.
Change-Id: I82ba90070ef4e739a0b5c4463ef03a807e26adfb
The platform support will be changing so we will remove this in the
mean time.
The patch also remove false positives for test failures.
Change-Id: I118010085d305883f521fa01a5fd341e775eea5a
This is due to the fact that we no longer use the requirements.
This was done in commit 34568342ce37586cff9fe3fe462d3e722a4d4c04.
From now one we will have a specific version that matches the
vmware-nsx version.
Change-Id: I528194276a39c9434d60312f13e358afab1c404b
Add simple script to setup mysql and postgresql databases, this script
can be run by users during testing and will be run by CI systems for
specific setup before running unit tests. This is exactly what is
currently done by OpenStack CI in project-config.
This allows to change in project-config the python-db jobs to
python-jobs since python-jobs will call this script initially.
See also
http://lists.openstack.org/pipermail/openstack-dev/2016-November/107784.html
Change-Id: Id2bdd67f7fefe4e36c246d4e2b091f8ddf7d23d1
Needed-By: I7d359b161909162e3e325c43797523cdff8a14be
As we known, Exceptions are raised by the sys.exit() function.
When they are not handled, no stack traceback is printed in the
Python interpreter. In this patch we have known main() got return
values(eg:0, 1), but it can't specifies exit status when terminate
the main thread by unusing sys.exit(). So when using sys.exit(main())
instead of main() may be more readable and reasonable.
Change-Id: If3c185c35220f5e185e9872a91898430d6353811
As bug 1568706 uncovered, we were using zuul-cloner
in our gate jobs; this was preventing our translation from
syncing.
After digging into this issue a number of changes in this
associated logic were found to not be in sync with neutron.
This patch updates out tox/tools logic to follow that of neutron.
In addition this patch fixes any pylint checks that were failing to
make pep8 pass.
IMPORTANT:
Please review closely, not only to the tools/tox updates but also
to the ignored pylint checks in the code. We only want to disable
checks where appropriate.
Change-Id: I6c5fee3ca3073ad079eac1636cc3b9ec45926a68
Closes-Bug: #1568706
This patch adds support to automatically generate config files
for vmware-nsx repo using oslo config generator[1] for all
VMware plugins.
Tox can be used to generate a sample config file using the
following command:
tox -e genconfig
This will generate a config file "nsx.ini.sample" under
vmware-nsx/etc/ folder.
This patch also modifies devstack scripts to use the
auto-generated config files and adds more information to help
texts in config modules.
[1] http://docs.openstack.org/developer/oslo.config/generator.html
Change-Id: Iff4ea37b52616295b262ead53947acb5b0cd9cd7
Partial-Bug: #1568215
Later, we'll backport the patch into stable/liberty and change the
branches used for neutron-*/networking-* dependencies there.
Change-Id: I16bd097f4619c7c898b290926bcbf2f5b31356bf
It is not a good idea to have a top-level "tools" namespace, this
name is too generic and already taken in PyPi (see
https://pypi.python.org/pypi/tools).
This patch moves python_nsxadmin to the vmware_nsx.tools namespace,
adjusting all imports and making sure setup.cfg is adapted
accordingly.
Change-Id: I75922db2010194fe59db424cc4615c7ba57c1b81
The cli args neutron-conf/nsx-conf we had until this
point to conf files not in the default locations didn't
work. This is because of the below code section,
https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2580
the above states reloading the conf options only from the
ones passed as --config-file. So that's the only way to pass
new config files to oslo.config.
So if someone wants to pass a custom neutron.conf/nsx.ini to
admin utility, they can do:
nsxadmin --config-file custom_path/neutron.conf --config-file
custom_path/nsx.ini -r <resource> -o <operation>
This patch removes neutron_conf and nsx_conf options from the cli
and users should use --config-file option to specify any config files.
Change-Id: Ia5048875fd465d46aa6f85cd02278d778eb6017e
On NSXT-BB setup, execution of nsxadmin throws
ImportError: No module named admin.plugins.common
so this patch fix that error
Change-Id: Iaf4781636440f510cf13926a4b539525af4a1db3
It wasn't working because of two reasons:
1. The packages filed in setup.cfg takes a directory name.
so specifying tools.python_nsxadmin.admin didn't put the py files
in /usr/local/lib/python2.7/dist-packages when we pip installed
vmware-nsx package. (sudo pip install .). So changing it to tools
installs all the code in tools including python_nsxadmin there. Read
2 to know why we need this.
2. To enable admin utility to dynamically pick up any hooks that users
might add we use the importlib module. The bug was here, as the path was
absolute tools/python_nsxadmin/.... So when we executed it from other
diretory those modules were not imported. So I changed that to relative
path. Though, over here there could be a case where the hooks location
directory path contains a '-' / dash, which will cause it to fail.
>>> import
>>> home.gangil.t1-review.e_nsx.tools.python_nsxadmin.admin.plugins.nsxv.resources.edges
File "<stdin>", line 1
import
home.gangil.t1-review.vmware_nsx.tools.python_nsxadmin.admin.plugins.nsxv.resources.edges
^
SyntaxError: invalid syntax
So we install the tools code using setup.cfg and then just import
resources from there.
Now it works from any directory.
Change-Id: Idc414fabc769d0503974e8f77b84d32008b3c08a
This patch dumps the tabulate package in favor of prettytable
since its a global requirement and is used by all openstack
clients. So users won't have to install a package separately.
We also refactor python-nsxadmin to python_nsxadmin. Since setup.cfg
does not like names with '-'
Change-Id: Ib510c7b40673b747e0712a656d19e18e4ff4accb
Fixes the case of the operations supported in the help message
of a resource.
Also fixes list of supported ops where we were listing all the ops
when a invalid op was specified instead of just the ops that are
supported *only* by the resource.
$ nsxadmin -r edges
Supported list of operations for the NSX-V resource ['LIST', 'CLEAN']
If user supplies -o LIST, it won't work. since the callback registration
is case sensitive. So to avoice any ambiguity we show the ops as lower
case.
Supported list of operations for the NSX-V resource ['list', clean'']
Change-Id: If41274181baf0f30502b8821169bbc6e4504ba2d