A recent change in pep/pycodingchecks introduced new warnings as part of
the pep8 target that causes pep8 to fail now.
This patch fixes code that issued warnings W503,E731,E266,E402
Change-Id: I57c035440bd847193ea5f8a8078016fb9baa3c31
Commit I944021cbb6dfc950cff353e0ac908fa2b9c29bfe added a code to
avoid adding the mac learning + no security profiles for ENS ports
upon creation.
This patch does the same for the port update action
Change-Id: I287ccbc85c1a8ec201650b1d7b9ce9e603044815
The NSX will not accept 0.0.0.0/0 for remote and local IP
prefixes. This is changed internally to 'ANY'
The 'ANY' will only be internal. The API for the user will not
change, they will stell see the 0.0.0.0/0
Change-Id: I24adc9da9f52d17621117b46d8a535ccedf93227
When removing or changing the gateway of a router, we should not
set the edge-cluster id to None, and the NSX backend does not
support it.
Change-Id: I46e3ccdf1f3325ff0f6995b40146e26fe5a195d9
LBaaS forreign key migration adds several foreign keys, to enforce the
cleanup of stale NSXv DB objects when the LBaaS object is being deleted.
However, garbage rows may exist - and must be cleaned up prior to the
creation of the foreign key.
Change-Id: Ie6a0348df8b19a49525a1f2bad89f12370a3cd46
Since oslo.utils provide the ability to generate the uuid string,
and some others use oslo.utils[0] too. For consistency, this ps
replaces uuid.uuid4() with uuidutils.generate_uuid().
Change-Id: I9b3ebff137d0ffaed8c54031c8587c3bfc1acdce
Bug fix 2082554: handle the exception in neutron side for Qos
since its not supported from NSXT for ENS TZ
Change-Id: I8ca4c7d04286830ce785a60d7a24439b9a39d801
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
When neutron VPNaaS is not configured, the NSX plugins should
come up and work even if the neutron-vpnaas code is not installed.
This patch moves a constant the plugin needs to a file without
neutron_vpnaas imports so that the plugin doesn't have to import it.
Change-Id: I4c0893128fe8fd9c4797531bdb31d6407d18f034
When neutrion FWaaS is not configured, the NSX plugins should
come up and work even if the neutron-fwaas code is not installed.
This patch adds try/except on fwaas imports, and some mocks to
allow it.
Change-Id: I44895c1ded046668c56d559b47a69c44102d2f04
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: Ia65cd41c6d0f4a4847458188cc5afddb06035a23
When the default TZ is a ENS VLAN TZ then we identify this this
is not a regular overlay network. It is a VLAN network. There was
a missing check for regular networks that were not provider
networks.
Change-Id: I9e4241fd2e1047ba14442babc4677efa4dcab3a5
This patch will allow users to filter ports according
to security_group supplied as a filter.
Code is for V and V3.
Change-Id: I20b4655cb188aae9d031fee20aea917268ebdf48
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
The VPNaaS uses a neutron port to allocate a local peer ip.
This port should not be updated or deleted by the neutron users.
Change-Id: I5c0e823ebd1fe79cb3ccdf175f760b16d5e2f562
This patch adds the py27-dev and pep8-dev tox targets that enable local
(outside the gate) running of py27 and pep8 using master branches from
our sub-project dependencies as discussed in [1] in editable mode.
If additional local/dev targets are needed (ex functional) they can be
added in the same fashion as shown herein.
With this patch to run pep8 locally use:
tox -e pep8-dev
And to run py27 locally:
tox -e py27-dev
The editable projects will be under .tox/{env}/src/
This patch also adds to our devstack/lib scripts by cleaning out any
existing (dependency git) projects and installing them in editable mode
from git.
Depends-On: https://review.openstack.org/552865
Depends-On: https://review.openstack.org/554297
[1] http://lists.openstack.org/pipermail/openstack-dev/2018-March/128328.html
Change-Id: I4d0dcba15e5b30e4cfa7335edf9c2dd961530184
a No-SNAT router subnets cannot overlap with VPN subnets becasue of the rotuer
advertisment.
This patch adds validations when changing the rotuer GW or addign an interface.
Also change the local endpoint port creation so this port will have a distingished
name and device id/owner and won't be queried by mistake.
Change-Id: I41faf97bae67ca85b38da3ade47894865eac8d51
Remove tox_install.sh, we have now all dependencies in
global-requirements and don't need this setup anymore.
Update tox.ini for this, move constraints into deps for proper
working.
This enables proper installation of dependencies from git.
Depends-On: https://review.openstack.org/552865
Depends-On: https://review.openstack.org/554297
Change-Id: I49d432bdf01221d0244449c4e2be807d0f646afa
The NSX currently does not support trunking for DHCP and
metadata ports. When a network and subnet are create we will
not create these if transparent VLAN is set on the network.
Change-Id: I7f8c4c81ba5074c58e61d31b08e0af66ef43accb
devstack should succedd for TVD plugin even if the V3 transport zone
is not configured, sonce it can work with v/dvs plugins.
Change-Id: I889a9cdfd2a79c26be4c5ab0f880b33fa6b2a384
Commit I34d72b12289d6f6527bc114a32dac88281dd2cc4 added NO_DNAT rules
for each router interface. Those rules are not supported and unnecessary
for older NSX versions as VLAN networks were not supported with routers.
This commit adds the NO_DNAT rules only when supported.
Depends-on: I4d99193caac6940911cc071016359a1361428967
Change-Id: Ic0934979931e20645ee1d7d6b5968d7d3efc9c01
By default MAC learning is enabled on these networks. The patch
does the following:
1. prevent disabling this for TZ networks
2. marks the port mac learning as enabled on create
3. does some minor optimization in reading id the port is on a TZ
network
Change-Id: I944021cbb6dfc950cff353e0ac908fa2b9c29bfe
