11858 Commits

Author SHA1 Message Date
Boden R
7223bbf963 migrate to stestr
ostestr is no longer installed by default by infra and will be totally
removed longer term; stestr [1] is its replacement.

This is the reason out gate is failing with the following today:

nsx/tools/ostestr_compat_shim.sh: ostestr: not found

This patch moves us to stestr by:
- Updating tox.ini to use stestr rather than call ostestr_compat_shim.sh
and in turn ostestr.
- Removing ostestr_compat_shim.sh as its no longer used.

For more details on stestr see [1].

Also note that this is a quick migration to stestr to get the gate
working; additional tweaks may come up.

[1] http://stestr.readthedocs.io/en/latest/MANUAL.html

Change-Id: I9a871d3542c2f2615d757c0009ea3d6695f0e3f7
2018-03-05 14:54:00 -07:00
Boden R
527eca9f73 use plugin common utils from neutron-lib
The public APIs that are part of neutron.plugins.common.utils were
rehomed into neutron-lib with Iabb155b5d2d0ec6104ebee5dd42cf292bdf3ec61
and will removed in neutron with commit
I1d63cbea463e92e1d2e053f8e1a564ed52cb84f8

This patch consumes the common plugin utils from neutron-lib

Change-Id: I54ef960de54bc3ae781af7ba9473729c94197d0d
2018-03-04 09:53:45 +00:00
Zuul
ec4fb7ab48 Merge "use common agent topics from neutron-lib" 2018-03-04 09:52:12 +00:00
Boden R
5106963756 remove SHARED constant that now lives in neutron-lib
The SHARED constant was rehomed into neutron-lib with commit
If123044496b54a8bfc115ab41b8506ec5d7ba5a3
This patch removes the SHARED constant from vmware-nsx and switches all
uses to neutron-lib's version.

Change-Id: I8ab75021399b5a85f5bfe8de858d8c4309b741dc
2018-03-01 15:51:12 -07:00
Adit Sarfaty
2825e30777 AdminUtils: Improve NSXv security admin utils
1. Better explain the security groups / nsx security groups / firewall sections
admiun utilities.
2. Also remove the unrelated firewall sections reorder form the fix-mismatch utility
3. fix some warnings that appeared when runnin g the utilities
4. Add new utilities to list/clean unused NSX sections:
- List NSX firewall sections that does not have a matching neutron security group::

    nsxadmin -r firewall-section -o list-unused

- Delete NSX firewall sections that does not have a matching neutron security group::

    nsxadmin -r firewall-section -o nsx-clean

Change-Id: Ie9868d1fb196964ce479bca2c42d4a6eea7ef427
2018-03-01 14:11:38 +00:00
Adit Sarfaty
7b26f1a98f NSX-V3: Fix AZ retrieving for DHCP profile
When getting the AZ of a network for its DHCP profile, we need to
use the az-by-id api, so that the hints data is initialized correctly

Change-Id: I47525564af3622899b4f9ea1284207ec5c007679
2018-03-01 11:01:18 +02:00
Boden R
cd1fef8a81 use common agent topics from neutron-lib
The neutron.common.topics module was rehomed into neutron-lib with
commit Ie88b84949cbd55a4e7ad06341aab77b286cdc485
This patch consumes it by using neutron-lib's version of the module in
prep for Ia4a4604c259ce862597de80c6deeb3d408bf0e95

Change-Id: I34fb241499445e2a462b10815a26b79bded0fb78
2018-02-28 13:10:15 -07:00
Zuul
2a81af0b7f Merge "fix Parameter spelling error in unit test" 2018-02-28 14:19:02 +00:00
Zuul
49e30433ac Merge "NSX-V3 Add NO NAT rules for router interfaces" 2018-02-28 10:44:22 +00:00
Zuul
8b3c077434 Merge "Enable configuration to decide on vlan tag per TZ" 2018-02-28 10:27:51 +00:00
wangqi
5f5d555561 fix Parameter spelling error in unit test
Change-Id: I3e540a026d8b885908ae4415cfbe026afa452f7f
2018-02-28 08:24:05 +00:00
Michal Kelner Mishali
ab622863d5 Enable configuration to decide on vlan tag per TZ
NSX|V3: This feature will enable an admin user to configure a range
of VLAN IDs per VLAN Transport Zone, so when they create a VLAN,
the VLAN tag will be set accordingly.
The configuration is being done in the nsx.ini file, under the relevant
section for nsx-v3, the admin will note the tz-id, with either a
predefined range(s) (min/max values) or only the transport zone itself
(which means that any value can be chosen).
The admin user will create the network noting “provider:physical_network”,
if they select a VLAN ID, than it will be used, if not - one will be
chosen according to the configuration mentioned above.
New configuration variable in nsx.ini under nsx_v3: network_vlan_ranges
network_vlan_ranges=<TZ_UUID>:<min_val>:<max_val>

Change-Id: Id202ca28bda44286deacb5c9969ffd92aa564a90
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
2018-02-28 09:51:17 +02:00
Adit Sarfaty
e7111bd5a7 NSX-V3 Add NO NAT rules for router interfaces
For each router interface subnets, we need to add NO DNAT rule whenever
NAT rules are added, or else internal traffic will be blocked.

Change-Id: I34d72b12289d6f6527bc114a32dac88281dd2cc4
2018-02-27 12:59:11 +02:00
melissaml
c718a4fb2a fix url in HACKING.rst
Change-Id: I59952f0654024daf9cc39fda7212d20b6b89e56b
2018-02-26 02:48:28 +08:00
Zuul
895c25d2df Merge "NSX|V3: router attached to VLAN must have gateway" 2018-02-25 12:19:25 +00:00
Zuul
f9e3bf72a2 Merge "TVD IPAM support" 2018-02-22 13:08:00 +00:00
Gary Kotton
70518f2c19 NSX|V3: router attached to VLAN must have gateway
Validate that the router does not remove the gateway if a VLAN is
attached. This is due to the fact that the router is centralized
and must be on a edge cluster.

Change-Id: I0d2d0ddb3c4beb8beeac9942db1e0259a5faf3a7
2018-02-22 02:33:46 -08:00
Zuul
36bb519b93 Merge "TVD: Admin utility for migrating a project" 2018-02-21 11:31:49 +00:00
Adit Sarfaty
db005d3221 TVD IPAM support
Adding an IPAM driver for the TVD plugin which will redirect the
requests to the V/T driver.

Change-Id: Iea48c7de053b0e7545fdae2a8e38c7b489d61409
2018-02-21 12:38:56 +02:00
Adit Sarfaty
863daeafef TVD: Admin utility for migrating a project
Initial version for an admin utility for migration of a project
from V to T
This code will first dump all the objects to a file, so the data
will not be lost.
Then it will delete each object using the V plugin,
move the project to the T plugin and recreate each object.

Usage:
nsxadmin -r projects -o nsx-migrate-v-v3 --property project-id=<V project to be migrated>
--property external-net=<T external network to be used>

Change-Id: I816b63f40ada945d321db4566224f8a964a39a8f
2018-02-21 10:58:14 +02:00
Zuul
d62cacf2d7 Merge "TVD: Add service plugins to separate list results" 2018-02-21 08:29:54 +00:00
Zuul
7ee3ce1c02 Merge "NSX-V Admin Utils: List BGP GW edges" 2018-02-21 08:29:51 +00:00
Adit Sarfaty
db7ec67010 NSX-V Admin Utils: List BGP GW edges
Usage:
nsxadmin -r bgp-gw-edge -o list

Change-Id: Icc82895e6c981ec35b2dbb31c32ceaa05d9e9f11
2018-02-20 14:26:03 +02:00
Adit Sarfaty
a9a79312e0 NSX-V3 add ens_support arg to devstack
Change-Id: I732a14a0be33fb474c297850928b72987efefcba
2018-02-20 12:05:08 +02:00
Adit Sarfaty
c6c155c1aa TVD: Add service plugins to separate list results
Adding service plugins for QoS, VPNaaS and L2Gateway
and updating the BGP plugin
to prevent users from getting objects belonging to a different
plugin

Change-Id: I3545c3acefaf50ca6937a0b7a65c131c569317cd
2018-02-20 10:34:18 +02:00
Adit Sarfaty
13ded44bc9 NSX-V3: do not add the DHCP profile for ENS networks
ENS networks/ports does not support any security profiles

Change-Id: I2d0bb5b78c0953f70c5ae045425bd2465090ba4c
2018-02-20 08:11:40 +02:00
Zuul
8f513e2d9a Merge "NSX|TVD: add ability to add extra filters" 2018-02-19 19:24:23 +00:00
Zuul
783d275dab Merge "NSX|V: ensure that no sec groups and port sec will discard traffic" 2018-02-19 17:54:01 +00:00
Zuul
e9048e1712 Merge "NSX|V: treat edge case when spoofguard entry already exists" 2018-02-18 10:45:14 +00:00
Gary Kotton
595fe2e5ab NSX|V: treat edge case when spoofguard entry already exists
Treat a case where the spoofguard entry exists. One edge case may
be a reschedule and the port is not cleanued up.

Change-Id: I95fbbbd97d6ce1de55fe5a1f5016459e4fb200f9
2018-02-17 23:56:12 -08:00
Adit Sarfaty
d97a333d21 NSX-v3 VPNaaS: Use a local address from the external network
The local address of the local endpoint for the VPN should be an unused
address on the external GW network of the Tier1 router
(and not the GW address itself).
To make sure this IP will not be used for anything else, a neutron port is
created.
The port will be deleted once the router (or its gw) is deleted.
The ip will be used for all the vpn services & connection on this tier1 router.

Change-Id: If956fd08f5c9cfde5cba9326c18d1d489c47a505
2018-02-18 06:28:11 +00:00
Gary Kotton
33be140a6e NSX|TVD: add ability to add extra filters
Certain resources require certain filters. For example, a V user,
where the service tenant is T will not show the IP addresses on the
'nova list' command. This requires that the 'id' be filtered.

Change-Id: I8b563d1b80974bcee3ed839eaec202052a8ec784
2018-02-17 02:58:19 +02:00
Gary Kotton
6362e710d9 NSX|V: ensure that no sec groups and port sec will discard traffic
Traffic to ports that have port security and port security enabled
will by default be discarded. A configuration variable has been added
with default False so that there is not a degradation with the current
behaviour.

The variable is use_default_block_all.

Change-Id: I5569234de01c116d1ad3161cfaf54404467f6816
2018-02-17 01:12:12 +02:00
Gary Kotton
9dfd71b70f release note update
Add the queens release note info.

Change-Id: I5f3f57082dbfe5877d8de04343fca0c04ea47082
2018-02-17 00:52:20 +02:00
Zuul
5d6e3ee194 Merge "AdminUtils: Skip housekeeping on admin utils calls" 2018-02-15 16:53:51 +00:00
Adit Sarfaty
2e361c1222 TVD: Make sure lbaas subnet belongs to the correct plugin
When creating a loadbalancer via TVD, we need to verify that the assigned
subnet belong to the same plugin as the lasdbalancer

Change-Id: Ia4a288177b06e5e795b3b7753d8571b36700f5b3
2018-02-15 15:54:40 +02:00
Adit Sarfaty
de0081629e AdminUtils: Skip housekeeping on admin utils calls
The NSX-V housekeeping jobs should not run via the admin utilities.

Change-Id: Id8564d7514b2ca2d59804d95ad3912ecb833f54b
2018-02-15 13:28:35 +02:00
Zuul
6b8c66140d Merge "TVD: fix get_<>s but plugin with filters" 2018-02-15 08:44:38 +00:00
Zuul
92ceda6124 Merge "use is_extension_supported from neutron-lib" 2018-02-15 08:38:15 +00:00
Adit Sarfaty
57d6b97ec8 TVD: fix get_<>s but plugin with filters
When getting networks/ports/etc with filters, we should filter by
the context plugin even if filters are added to the request,
unless the filters are very specific.
For example - when filtering by device id, the project should be ignored,
or else router GW ports (which have no project) will not be deleted.

Change-Id: Ib41bb5eca39ae0cd6b16ead60db0ecd528eb4638
2018-02-15 09:07:06 +02:00
Zuul
bda748b149 Merge "resource2 is depracted, use resource" 2018-02-14 12:06:33 +00:00
Boden R
67322c3ba2 use is_extension_supported from neutron-lib
The is_extension_supported function now lives in neutron-lib. This patch
uses lib's version rather than neutron's in prep for commit
Iccb72e00f85043b3dff0299df7eb1279655e313e

Change-Id: Icdfab398a452b4c1ee98863e88dbb6708e42a12c
2018-02-13 10:58:36 -07:00
Zuul
1b7563b926 Merge "TVD Fwaas: prevent adding wrong plugin routers to FW" 2018-02-13 16:47:44 +00:00
Gary Kotton
d13ac26f07 resource2 is depracted, use resource
Change-Id: I6870d129e4241377ab28d9fb9c4963e87845f5a5
2018-02-13 06:23:50 -08:00
Adit Sarfaty
ae3b8b33dd TVD Fwaas: prevent adding wrong plugin routers to FW
Validate that the router assigned to the firewall belongs to
the same core plugin

Change-Id: I602660700aaf65408c62e19c66aa812239eb7f98
2018-02-13 16:09:53 +02:00
Zuul
d126c5c69f Merge "admin utility enabled nsx-update for security groups (V and T)" 2018-02-13 13:02:38 +00:00
Zuul
8cedbf08a7 Merge "Tag the alembic migration revisions for Queens" 2018-02-13 13:02:37 +00:00
Gary Kotton
5ffb1de1e6 admin utility enabled nsx-update for security groups (V and T)
Provide ability to update security groups on NSX

Change-Id: Ia16dfcd5618a3584bc9d0acfbf8a0de155997e58
2018-02-12 08:18:55 -08:00
Zuul
1735720753 Merge "Remove pbr warnerrors in favor of sphinx check" 2018-02-12 12:52:53 +00:00
Adit Sarfaty
d6fbcb9134 Fix admin utils doc
The config resource belongs to the V3 plugin + make the plugins headers
more noticable

Change-Id: If35fb4d7d01810de81bda813838ab37d0ba837c7
2018-02-12 09:51:11 +02:00