11858 Commits

Author SHA1 Message Date
Zuul
bab5abe82d Merge "Revert "use str names rather than classes for orm relationships"" 2018-03-18 15:56:39 +00:00
Zuul
341314742a Merge "NSX-V3 Fix some VPNaaS configuration bugs" 2018-03-18 15:48:19 +00:00
garyk
ec9ff32ac6 Revert "use str names rather than classes for orm relationships"
This reverts commit dec28f6d2b83700e96180b1b10b712799f0c76f7.

We needed to revert this as it broke the nsx cleanup utility
for NSX|V. This broke the CI.

Change-Id: Iffb05ab0c0bcb8c8184a0c821dece1e88cdd3fb3
2018-03-18 13:32:27 +00:00
Adit Sarfaty
a494a35444 NSX-V3 Fix some VPNaaS configuration bugs
- Support the case of empty neutron names
- Fix NSX local endpoints tags
- Support connection/service admin-state configuration

Depends-on: Ieb9da32b6f3b908dda7b4c5b99cb4ca2b79c9286
Change-Id: If5509fdcf3c496ad446921a3fb57b48deb6179f4
2018-03-18 14:23:56 +02:00
Zuul
b3e9311686 Merge "TVD: configure the list of supported plugins" 2018-03-18 10:15:14 +00:00
Zuul
f4d0ceb23d Merge "TVD: Support TVD devstack with disabled plugins" 2018-03-18 09:40:22 +00:00
Zuul
b856a2eb66 Merge "Updated from global requirements" 2018-03-18 08:47:49 +00:00
Adit Sarfaty
ab6f32c12b TVD: Support TVD devstack with disabled plugins
When using the TVD plugin, sometimes nsx-v or nsx-v3 are not configured.
This patch ensures that the devstack cleanup will clean only the relevant
NSX backend, to avoid errors in the logs.
And also that the devstack configuration will skip unconfigured plugins

Change-Id: I27ad52ea9a4052c0b8f3d1ea4d485fcc44b19f6d
2018-03-18 08:08:56 +00:00
Gary Kotton
0356a7909c NSX|V: fix for existing spoofguard policy
Ensure that the policy is published.

Change-Id: Iba2ecd86e88ee4523b1af30554c6318b345059bc
2018-03-16 14:09:27 +02:00
OpenStack Proposal Bot
8bb8b5a7b9 Updated from global requirements
Change-Id: I1e890f5e1e4bf5f76fb30db84327c2ca6a4f03a0
2018-03-16 03:55:37 +00:00
Andreas Jaeger
8b06741ad7 Move neutron to requirements
Move neutron to requirements.txt Since neutron is now in
global-requirements, we can remove the installation from
tools/tox_install.sh.

Change-Id: I3d5aa6d61d1601358f6972a606c5a0a6fb5c2dd0
2018-03-14 21:17:17 +01:00
Adit Sarfaty
3e49ed86b4 TVD: configure the list of supported plugins
Instead of always trying to load all 3 plugins (v, t, dvs), the customer
can now configure those he wishes to support.
This way we will be quicker on neutron restart (and CIs) and avoid the errors
in the logs.

Change-Id: I9b41dc4002e7bd758dd46810763e70dbfc9202b0
2018-03-14 12:15:53 +00:00
Zuul
1a7368c13f Merge "NSX-V3: Update NSX objects on network update" 2018-03-13 19:04:37 +00:00
Zuul
c52d97012b Merge "L2GW: support missing methods" 2018-03-13 13:13:51 +00:00
Zuul
0c4df71650 Merge "NSX|V3: ensure that description is not None" 2018-03-13 13:13:45 +00:00
Zuul
d84f2f01ac Merge "Fix security groups ext_properties loading" 2018-03-13 10:08:42 +00:00
Gary Kotton
15a279dbc6 L2GW: support missing methods
Adds missing methods. Something changed witht he way in which
the callbacks were invoked which showed that we did not support
the correct methods.

Change-Id: I253ceee343d829923b874057603a32ccd8c662f6
2018-03-13 08:50:54 +00:00
Gary Kotton
b5a195ecc4 NSX|V3: ensure that description is not None
Commit a96d83ece64d1ab662be8ee62eca15c3e3ab4c19 set the internal
security group description to be None. This should be a string.

Change-Id: Ia4b1e0cea3f4e1493e41bf1e97bcf3016e389bf9
2018-03-13 08:50:47 +00:00
Adit Sarfaty
f9071f3f9f Fix security groups ext_properties loading
Commit I123ae390bec489a931180a2e33f4bf7b1d51edb2 broke the extended
security group code, by removing the 'is_default' attribute from the
list of fields that should have been updated in the DB.
Not sure exactly why it broke us.

Change-Id: I891bc792e62ac90683ce8745f98a3139c9ffd3d9
2018-03-13 08:09:05 +00:00
OpenStack Proposal Bot
59509abbb0 Updated from global requirements
Change-Id: I1c2a9f3a0413d01e8cd21a9162f5fadda157b814
2018-03-13 07:38:00 +00:00
Zuul
5a25e38e8b Merge "TVD: Fix get-floatingips plugin selection" 2018-03-12 07:02:37 +00:00
Zuul
df79a8634e Merge "AdminUtil: V3 refactor get md_proxy_status" 2018-03-11 14:24:01 +00:00
Adit Sarfaty
476b3b924b TVD: Fix get-floatingips plugin selection
When getting floating ips by port id, we should ignore the requesting
tenant since this is called via nova with a service tenant.

Change-Id: I557a9bb7071481e15c8be064a14cad583140991f
2018-03-11 15:34:03 +02:00
Zuul
f96fdeab73 Merge "NSX-V: Avoid warning on deleting dhcp binding for non compute port" 2018-03-11 12:59:55 +00:00
Michal Kelner Mishali
dbe86b248a AdminUtil: V3 refactor get md_proxy_status
Depends-on: I9b4e8520965878c949bee5129fa5c20a4b80671d

Change-Id: Iafb8f2b5ab7af089e41fcc86fe21509f3da03f88
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
2018-03-11 12:42:16 +00:00
Adit Sarfaty
e8d446d6d4 NSX-V3: Update NSX objects on network update
When the neutron network updated, some related NSX objects may need
be updated as well: DHCP server & port & metadata port

Depends-on: I07658bdaabe919f94dc877585206c76a1191f16c
Change-Id: Id563788af4b41aa360f8e87b28c310d1bab33feb
2018-03-11 12:35:30 +02:00
Adit Sarfaty
b565c4bda3 NSX-V: Avoid warning on deleting dhcp binding for non compute port
When a port is deleted, the plugin should delete its backend dhcp
static binding only if it is a compute port, since it is added
only for compute ports.
Note that the case of changing the device owner of the port was already
handled in the update-port code.
Calling the delete on non-compute ports issues a warning in the logs
We keep callign it anyway to avoid edge cases but will skip the warnings.

Change-Id: I5e76b14de0c2f2b844c7411bc325e46746fda54d
2018-03-11 11:56:32 +02:00
Zuul
b83b3de5d0 Merge "Updated from global requirements" 2018-03-11 08:58:03 +00:00
Boden R
dec28f6d2b use str names rather than classes for orm relationships
In Rocky we are going to start working on decoupling neutron db. This
will be a long effort, so from a vmware-nsx POV we can hopefully pick
away at it as we go.

This patch changes to use of class references to fully qulified class
names when defining ORM relationships. This allows us to remove a few
of the neutron db related imports in vmware-nsx.

Change-Id: I1df4cb3eec59488a5b35fac9f943bbfdbb44df63
2018-03-11 06:56:23 +00:00
OpenStack Proposal Bot
ae9a922faa Updated from global requirements
Change-Id: I0ea4819a924912d4c89c33b75f8e90f9a6c4e081
2018-03-10 14:00:04 +00:00
Gary Kotton
02f4ccb6bb NSX|T DFW support
Commit c211f02e642f0339077fb9d37c3452132e1163f9 deleted two lines
by mistake. This returns them.

Change-Id: I612074358af58cd6d63764be6862c6c77d2ccc5b
2018-03-09 13:50:40 +00:00
Zuul
6a6a7b9db4 Merge "NSX-V3: verify router transport zones" 2018-03-08 13:59:57 +00:00
Zuul
9b8ee7abf8 Merge "Remove old TODO comments" 2018-03-08 11:51:07 +00:00
Zuul
9631a35b5d Merge "AdminUtil: using nsxlib func for orphan dhcp rm" 2018-03-08 11:51:06 +00:00
Adit Sarfaty
f0fb8eab09 NSX-V3: verify router transport zones
The tier0 router should belong to the same transport nodes as
the subnets attached to the tier1 router which uses this tier0 as a GW

Change-Id: Idf216699ce110e8cd790779d3c4e63522800a845
2018-03-08 12:43:04 +02:00
Michal Kelner Mishali
1427c83397 AdminUtil: using nsxlib func for orphan dhcp rm
Removing abuse and using get_by_attachement function
in nsxlib, in order to get the API url.

Change-Id: I68786ca57275d3d1e358b1b877947188823013c2
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
2018-03-08 11:29:30 +02:00
Adit Sarfaty
b7c6b4e4ad Remove old TODO comments
TrivialFix

Change-Id: I6cd1e96e40659f6fe24e7b4b9e7955ea2ce5e9ac
2018-03-08 08:44:07 +00:00
Adit Sarfaty
1e165b002a NSX-V3: Add router overlay TZ with GW
When setting the gateway of a logical router, we should set the
overlay transport-zone-id as well, to allow vlan switches traffic

Depends-on: I3a447202785b7b6ac320ddbb6a3f2cdeac1f78aa
Change-Id: If94474f907938e2997951f1a4e8269de45063ec5
2018-03-08 08:42:45 +00:00
Adit Sarfaty
cf80214fb4 Fix broken unit tests
Commit I5867f77fc5aedc169b42f50def0424ff209c164c added new security
groups tests which the MH plugin does not support.

Change-Id: I574f73b77f900e9650f47f806b6928f02883c76a
2018-03-08 06:47:26 +00:00
Zuul
096a935366 Merge "NSX-v3: Add default tier0 router to AZ config" 2018-03-07 13:40:36 +00:00
Zuul
3cac9174d8 Merge "NSX|V3: prevent duplicate default FW sections" 2018-03-07 09:29:19 +00:00
Adit Sarfaty
3e6b548984 NSX-v3: Add default tier0 router to AZ config
The nsx-v3 plugin can add default Tier-0 router configuration per
availability zone. The Tier-0 rotuer will be used as a default for
external networks creation in this AZ.

Change-Id: I18e917a6b3deb40429626f7f0018e5da7ab72a8b
2018-03-07 10:31:16 +02:00
Zuul
e83f4f7fdd Merge "NSX-V3 Add vlan transparent warnings on init" 2018-03-06 10:06:48 +00:00
Zuul
165bc4394b Merge "TVD: update port migration for V -> T instances" 2018-03-06 09:14:00 +00:00
Zuul
e3e4a3400d Merge "NSX-v3: Remove unused lbaas utils method" 2018-03-06 08:51:43 +00:00
Adit Sarfaty
28c87c28f9 NSX-V3 Add vlan transparent warnings on init
Plugin init should not fail in case vlan transparent is configured
while not supported by the backend.
Issue a warning instead.

Change-Id: Ie91d581ef74f2b8f9e8014c36d520b106aab3e9b
2018-03-06 10:39:33 +02:00
Gary Kotton
a96d83ece6 NSX|V3: prevent duplicate default FW sections
When the plugin starts it will check if the global NS group and
OS DFW section are created on the NSX. If not it will create these.
There is a edge case where two servers are started in parallel and
they both create the default section. This will lead to traffic
being dropped.

This is dealt with in the following way:
1. We store the default OS section and NS group in the database
2. If the entries do not exist then we create them, the DB will
   indicate if there is a duplicate and then the plugin will do a
   cleanup of the incorrect resources.

In order to do this we need asecurity group. A default global one
with ID 00000000-def0-0000-0fed-000000000000 is created.

If the admin wishes to delete the global section then she/he should:
1. delete the NSX section
2. delete the security group
3. restart the neutron service

Change-Id: Ide7a7c75efac3e49d51e522a11c77e754f3d1447
2018-03-06 00:39:29 -08:00
Gary Kotton
f634145a1e TVD: update port migration for V -> T instances
The patch does the following:
1. set instance vNIC to a common network interface
2. Live migrates to T cluster
3. Updates the instance vNIC to opaque network

Example:
nsxadmin -r ports -o nsx-migrate-v-v3 \
    --property project-id=01dd52ff4c7047f79f6259f916c83790 \
    --property host-moref=host-11 --property respool-moref=resgroup-9 \
    --property datastore-moref=datastore-22 \
     --plugin nsxv3

There is also an option to use net-name. The default here is 'VM Network'

Change-Id: I24d9df3f7a3dbd11dffb86427367b809e2b49409
2018-03-06 06:06:24 +00:00
Adit Sarfaty
c688beed08 NSX-v3: Remove unused lbaas utils method
The method get_lb_router_id is not in use

Change-Id: I9a526c4d8c81b808306ff9f93bf38c112dd56e5d
2018-03-06 05:36:06 +00:00
Zuul
a1bfbe9256 Merge "migrate to stestr" 2018-03-06 00:26:26 +00:00