zuul/nodepool
Code Issues Proposed changes

Remove unneeded todo comment

Browse Source 
This removes a todo about request deferring. This is not valid at this
point because we already locked the request and further are in a loop
that must run fast.

Change-Id: I2858a418fe0ed953e4a300c6d27fca10b65194ef
This commit is contained in:
Tobias Henkel
2018-10-15 14:20:52 +02:00
parent 552cc28f7f
commit 25f26165eb
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
nodepool/driver/__init__.py
View File

@@ -543,11 +543,6 @@ class NodeRequestHandler(NodeRequestHandlerNotifications,
elif not self.hasProviderQuota(self.request.node_types): elif not self.hasProviderQuota(self.request.node_types):
declined_reasons.append('it would exceed quota') declined_reasons.append('it would exceed quota')
# TODO(tobiash): Maybe also calculate the quota prediction here and
# backoff for some seconds if the used quota would be exceeded?
# This way we could give another (free) provider the chance to take
# this request earlier.
if declined_reasons: if declined_reasons:
self.log.debug("Declining node request %s because %s", self.log.debug("Declining node request %s because %s",
self.request.id, ', '.join(declined_reasons)) self.request.id, ', '.join(declined_reasons))