Dockerfile: add user to shadow file too
Without an entry in the shadow file, this user can't use sudo with the following error: account validation failure, is your account locked (which I include here for future googling because it's pretty obscure, you have to have this odd situation, or a pretty broken PAM to see it). The "nodepool" user (10001) is in the root group, which is why the uid_entrypoint script can update the /etc/passwd file. We need to change the ownership of the /etc/shadow file for this to work. It feels a bit weird, but there's no password to actually guess anyway. Change-Id: I8846757edffe31f96df58999d05727910c9fca43
This commit is contained in:
parent
ab1dc76dc7
commit
747e957263
|
@ -24,7 +24,13 @@ COPY --from=builder /output/ /output
|
||||||
RUN /output/install-from-bindep
|
RUN /output/install-from-bindep
|
||||||
|
|
||||||
### Containers should NOT run as root as a good practice
|
### Containers should NOT run as root as a good practice
|
||||||
RUN chmod g=u /etc/passwd
|
|
||||||
|
# although this feels odd ... by default has group "shadow", meaning
|
||||||
|
# uid_entrypoint can't update it. This is necessary for things like
|
||||||
|
# sudo to work.
|
||||||
|
RUN chown root:root /etc/shadow
|
||||||
|
|
||||||
|
RUN chmod g=u /etc/passwd /etc/shadow
|
||||||
ENV APP_ROOT=/var/lib/nodepool
|
ENV APP_ROOT=/var/lib/nodepool
|
||||||
ENV HOME=${APP_ROOT}
|
ENV HOME=${APP_ROOT}
|
||||||
ENV USER_NAME=nodepool
|
ENV USER_NAME=nodepool
|
||||||
|
|
|
@ -16,7 +16,8 @@
|
||||||
|
|
||||||
if ! whoami 2>&1 >/dev/null; then
|
if ! whoami 2>&1 >/dev/null; then
|
||||||
if [ -w /etc/passwd ]; then
|
if [ -w /etc/passwd ]; then
|
||||||
echo "${USER_NAME:-default}:x:$(id -u):0:${USER_NAME:-default} user:${HOME}:/sbin/nologin" >> /etc/passwd
|
echo "${USER_NAME:-default}:x:$(id -u):0:${USER_NAME:-default} user:${HOME}:/sbin/nologin" >> /etc/passwd
|
||||||
|
echo "${USER_NAME:-default}:!:18211:0:99999:7:::" >> /etc/shadow
|
||||||
fi
|
fi
|
||||||
fi
|
fi
|
||||||
exec dumb-init "$@"
|
exec dumb-init "$@"
|
||||||
|
|
Loading…
Reference in New Issue