zuul
/
nodepool
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 28088 \u003c28088@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Someone else replied on a comment you posted"}
Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"removed on reply"}
This commit is contained in:
Gerrit User 1 2023-02-20 22:33:36 +00:00 committed by Gerrit Code Review
parent cc341d470b
commit fffaa43791
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
fdc093a8de3cc6deb051be6a7aa3eede28eff80a
View File

@ -23,6 +23,24 @@
"revId": "fdc093a8de3cc6deb051be6a7aa3eede28eff80a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e23fd6af_48bd8ef6",
"filename": "nodepool/driver/aws/adapter.py",
"patchSetId": 1
},
"lineNbr": 418,
"author": {
"id": 1
},
"writtenOn": "2023-02-20T22:33:36Z",
"side": 1,
"message": "They\u0027re named this way because they are essentially alternate implementations of the main body of the uploadImage method. So read it as \"uploadImage: snapshot implementation\" or \"uploadImage: image implementation\".",
"parentUuid": "9b9caeca_86023a71",
"revId": "fdc093a8de3cc6deb051be6a7aa3eede28eff80a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -45,6 +63,24 @@
},
"revId": "fdc093a8de3cc6deb051be6a7aa3eede28eff80a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4e468ca4_981a7d41",
"filename": "nodepool/driver/aws/adapter.py",
"patchSetId": 1
},
"lineNbr": 511,
"author": {
"id": 1
},
"writtenOn": "2023-02-20T22:33:36Z",
"side": 1,
"message": "See other comment.",
"parentUuid": "93ce8792_b8fca914",
"revId": "fdc093a8de3cc6deb051be6a7aa3eede28eff80a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}