zuul/zuul-jobs
Code Issues Proposed changes

Fix dockerhub check in use-docker-mirror role

Browse Source 
We were checking if dockerhub is a valid key in the
zuul_site_mirror_info/mirror_info dictionaries but did so without
quoting dockerhub as a string. This meant ansible tried to look up
dockerhub as a variable producing this error:

  The conditional check 'dockerhub is in zuul_site_mirror_info' failed.
  The error was: error while evaluating conditional (dockerhub is in
  zuul_site_mirror_info): 'dockerhub' is undefined. 'dockerhub' is undefined

Fix this by quoting dockerhub so that we lookup the string as a key
instead of a variable.

Change-Id: Ie869b9b52fd0a5b70fc07548ce449937ed2c9589
This commit is contained in:
Clark Boylan 2024-11-20 14:12:55 -08:00
parent b007e86a0f
commit 589cccb055
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
roles/use-docker-mirror/tasks/main.yaml
View File

@ -2,7 +2,7 @@
when:
- docker_mirror is not defined
- mirror_info is defined
- dockerhub is in mirror_info
- "'dockerhub' is in mirror_info"
set_fact:
docker_mirror: mirror_info.dockerhub.url
@ -10,7 +10,7 @@
when:
- docker_mirror is not defined
- zuul_site_mirror_info is defined
- dockerhub is in zuul_site_mirror_info
- "'dockerhub' is in zuul_site_mirror_info"
set_fact:
docker_mirror: zuul_site_mirror_info.dockerhub.url